mirrors/arti.git/crates/tor-netdir/src/params.rs, branch derive-traits

tor-netdir: Resolve an XXXX about type ugliness

2021-12-08T17:32:44Z

We had no function to infallibly convert BoundedInt32<{0 or 1},H> into a u32, even though we could have. Because of that, we were treating weight_scale as an i32 when logically it's a u32 or a NonZeroU32. Moreover, it turns out we were using an incorrect minimum for the bwweightscale param, which would in theory have allowed the authorities to make us divide by zero. This patch introduces the necessary From<> implementation and uses it. It corrects the binimum bwweightscale, and prevents a division-by-zero issue in case weight_scale is zero.

Remove a couple of spec-related XXXXs in tor-netdir.

2021-12-08T16:12:33Z

I've opened torspec!54 to fill in the missing parts of the spec about these issues.

add semicolons if nothing returned

2021-11-25T13:20:37Z

More typo fixes that I forgot to save :(

2021-11-24T23:23:12Z

Allow type of timeout estimator to change at runtime.

2021-10-20T16:06:58Z

This is a big change, but it does simplify the type of Builder a little, and isolates locking across different (potential) timeout estimator types.

Initial backend implementation for guard node manager.

2021-10-07T14:45:42Z

There are some missing parts here (like persistence and tests) and some incorrect parts (I am 90% sure that the "exploratory circuit" flag is bogus). Also it is not integrated with the circuit manager code.

Typo fix in comment.

2021-09-29T17:49:07Z

Suppress a cognitive-complexity lint in tests

2021-09-09T18:20:55Z

Add guard-related network parameters.

2021-09-09T17:01:52Z

Use macros and traits to simplify the declaration of parameters.

2021-09-09T13:29:04Z

Previously, we'd have to declare the field for a parameter in one place, its default in a second, and its consensus key in a third. That's error-prone and not so fun! This patch changes the way we declare parameters so that we declare a structure once, and macros expand it to all do the right thing. This required a few new traits and implementations to ensure uniformity across the types that can go in parameters: We need every parameter type to implement TryFrom and to implement SaturatingFromInt32. Eventually we might want SaturatingFromInt32 to be a more generic SaturatingFrom, but that's not for now.