mirrors/arti.git/crates/tor-netdir/src/hsdir_params.rs, branch arti-v1.2.7mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.72024-03-13T16:30:53ZRun maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320cFix typos in doc comments2024-03-06T19:52:42ZTobias Stoeckmanntobias@stoeckmann.org2024-03-06T19:05:17Zurn:sha1:18db641cca83fa707b3a97fa2975f99063f08875tor-netdir: Add a unit test for HsDirParams::offset_within_srv_period.2024-01-24T16:42:43ZGabriela Moldovangabi@torproject.org2024-01-24T16:42:43Zurn:sha1:14445e8bb0f3daa9420a3330614eeb4874bf881dtor-hsservice: Make offset_within_srv_period() work with timestamps from newer periods.2024-01-24T15:58:55ZGabriela Moldovangabi@torproject.org2024-01-24T15:51:31Zurn:sha1:5050e8c367ba0fb09552d93d3878a193f45678f2
This fixes a bug where `offset_within_srv_period()` returns `None`,
instead of the offset of `when` from the start of the SRV of the
previous time period:
```
2024-01-24T15:24:46Z ERROR tor_hsservice::svc::publish::reactor: descriptor upload failed for HS service
allium-cepa2 and time period TimePeriod { interval_num: 19745, length: IntegerMinutes { value: 1440 },
epoch_offset_in_sec: 43200 }: error: Programming error: internal error (bug) at
/../arti/crates/tor-hsservice/src/svc/publish/reactor.rs:218:13: current wallclock time not within
SRV range?! (now=SystemTime { tv_sec: 1706109886, tv_nsec: 246572852 },
SRV_start=SystemTime { tv_sec: 1705968000, tv_nsec: 0 })
```
We need to be able to calculate this offset even if `now` is not within
the SRV range (because we upload the descriptor to the HsDirs of the
*previous* time period too).
Note a similar bug exited in `offset_within_period()` (which no longer
exists) too! That one was fixed in !1744:
```
Hidden services can have multiple "active" time periods for which they
generate descriptors. We need to be able to compute the offset of a
timestamp from the start of a given time period, even if that timestamp
falls within the "next" time period (for example, when publishing
descriptors for the "previous" time period, the `when` timestamp will
fall outside the `(start, end)` range of the "previous" time period).
```
tor-netdir, tor-hscrypto: Add function for computing SRV period offset.2024-01-24T11:22:53ZGabriela Moldovangabi@torproject.org2024-01-23T19:05:33Zurn:sha1:b487b7e8d6dfaaf7c65ea2ea30083d87dd1e785c
Part of #1166
Expose HsDirParams, and give it accessors.2024-01-23T13:57:16ZNick Mathewsonnickm@torproject.org2024-01-23T13:40:59Zurn:sha1:188e201622e345c220de77bf0edd006804271932hsservice: Make HsDirParams include the SRV lifespan.2024-01-23T13:34:29ZNick Mathewsonnickm@torproject.org2024-01-23T13:31:48Zurn:sha1:712a29e7c260d2dbabbf3f9a0dc3f4e8c956cc83
This is part of #1254.
Run maint/add_warning to add lint block everywhere2023-08-23T09:34:00ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-22T14:28:12Zurn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9acRun maint/add_warning to actually apply new lint allows2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T11:19:32Zurn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0Downgrade TODO HS on HsDirParams::compute().expect()2023-06-29T12:19:37ZNick Mathewsonnickm@torproject.org2023-06-26T18:12:55Zurn:sha1:c565a67689ba6d2b8b3f59448c66e9b4bf34e072
(Adding comments explaining that these errors are really
unlikely to occur, unless there is a bug in our code or in Rust's
time handling.)