mirrors/arti.git/crates/tor-memquota/src/mtracker.rs, branch arti-v1.2.8mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.82024-09-10T11:42:37Ztor-memquota: Use checked_sub .. expect in two places (fmt)2024-09-10T11:42:37ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-10T11:41:58Zurn:sha1:e3b8c4646e2d28c52ffdd23dea5bee24a3f2a626tor-memquota: Use checked_sub .. expect in two places2024-09-10T11:42:37ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-10T11:35:09Zurn:sha1:0c8d6abd3501769427fbde1393f9b2c947c2fd94
In these two places, underflow is statically impossible, but
demonstrating that to the compiler is probably too onerous.
tor-memquota: Provide reconfigure method2024-09-04T12:26:47ZIan Jacksonijackson@chiark.greenend.org.uk2024-08-28T15:43:59Zurn:sha1:4e5bd7c9413c377d72dab864b5174adff6bb4698tor-memquota: Rework optionality configuration2024-09-04T10:47:56ZIan Jacksonijackson@chiark.greenend.org.uk2024-08-27T13:19:49Zurn:sha1:12f233e9c0f301a247edb44df67f1c60027d765e
Allow a `Config` to represent "this is supposed to be disabled".
This involves wrapping the actual built configuration in an IfEnabled.
We treat max = usize::MAX, or max being unspecified, as "disable".
We can now reporting an error during config building if max is set but
we're compiling the feature out. Conversely, we can now make
`MemoryQuotaTracker::new()` unconditional, since enabled
confiogurations are uninhabited when the feature is compiled out.
We change how we derive the setters, deriving them from the Builder.
I chose to abolish the use of derive_builder. See the new comment on
ConfigBuilder.
Fix typos2024-09-03T08:09:02ZDimitris Apostoloudimitris.apostolou@icloud.com2024-09-03T08:09:02Zurn:sha1:676f913463b7d84f34dd6101b99d03ef79cf57adtor-memquota: Pass EnabledToken to IsParticipant methods2024-08-19T17:10:29ZIan Jacksonijackson@chiark.greenend.org.uk2024-08-19T13:34:47Zurn:sha1:4c98ef1468f2ead3876a8f886d3a5a33c550a492
This will hopefully allow much caller code to be compiled out.
The users (IsParticipant impls) don't generally need to bother with
it - they can just ignore it.
tor-memquota: Put EnabledToken in various structs, including the reclaimer2024-08-19T17:10:29ZIan Jacksonijackson@chiark.greenend.org.uk2024-08-19T14:36:14Zurn:sha1:53f6d7e8d88943bd8182570557cb2776ae8b0009tor-memquota: Allow memory tracking to be compiled out2024-08-19T17:10:04ZIan Jacksonijackson@chiark.greenend.org.uk2024-08-19T13:43:24Zurn:sha1:d04d130f0155eae98bc6e9d532f09ae3bfd308c4
Now if we run doctests without the feature enabled, we test that a
no-op MemoryQuotaTracker works.
Those tests aren't currently run in CI, but they will be after !2350.
tor-memquota: Support a no-op MemoryQuotaTracker2024-08-19T14:42:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-08-19T14:40:09Zurn:sha1:5a94ebb8c7df52ad2662edd79304d7c946efc36e
Wrap up most of the structures in IfEnabled.
Sadly this diff is very noisy. I experimented with macros for the
little enabled check at the start of each function but they didn't
really help.
We don't test this yet. We'll do a smoke test of this later.
tor-memquota: Introduce self_ variables in mtracker.rs (fmt)2024-08-19T14:41:34ZIan Jacksonijackson@chiark.greenend.org.uk2024-08-19T14:17:14Zurn:sha1:fe88fae98fe504c4d318548ebfbf6493156e4388