mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.8.0 2025-09-08T21:12:10Z 2025-09-08T21:12:10Z Wesley Aptekar-Cassels me@wesleyac.com 2025-09-08T21:10:33Z urn:sha1:e3081529a0aa68bf74554b3a176717b4ba4c8c41 As discussed with gabi on IRC today. 2025-08-07T15:28:36Z Nick Mathewson nickm@torproject.org 2025-08-06T01:19:58Z urn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc First, run ``` git grep -l "^edition =" | xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;' ``` Second, manually verify that all Cargo.toml files have changed, and nothing else has changed. Third, run cargo fmt again. 2023-11-29T17:42:03Z Nick Mathewson nickm@torproject.org 2023-11-29T17:42:03Z urn:sha1:4ee2039934e4e87919eba9496eaf2645055f2c73 2023-11-29T17:10:18Z Nick Mathewson nickm@torproject.org 2023-11-29T17:10:18Z urn:sha1:adc3209c6bef9cc03542c31c22c0f308938e1643 With this change, we no longer expose the ExpandedSecretKey unescorted, which makes it harder to misuse the API. 2023-11-29T15:55:04Z Nick Mathewson nickm@torproject.org 2023-11-29T15:49:26Z urn:sha1:7fb24cb69da537ac04ab2dae80997c6d481622ef This code was needed with the old version of dalek-cryptography, which wasn't compatible with up-to-date versions of the `rand` crate(s). But now that we've upgraded, we can drop this. (We could have left it around and deprecated it, but we are already making a breaking change to tor-llcrypto by upgrading dalek-cryptography.) 2023-11-29T15:34:58Z Nick Mathewson nickm@torproject.org 2023-11-21T15:58:29Z urn:sha1:98037a2c788bd901679139178d25f855324637f3 The main changes that we have to adjust for are as follows: * In x25519-dalek: * `StaticSecret` is now behind a feature. * `StaticSecret::new` is deprecated in favor of `StaticSecret::random_from_rng`. * StaticSecret no longer does its own clamping. * In ed25519-dalek: * `SecretKey` has (in effect) been renamed to `SigningKey`. The name `SecretKey` is now an alias for `[u8; 32]`. * `SigningKey` is effectively a keypair, since it contains a public key as well. * `PublicKey` has been renamed to `VerifyingKey`. * The functions to extract a signing key and verifying key have been renamed as you might expect. * `ExpandedSecretKey` has been moved to `hasmat` and no longer implements `sign`. * `ExpanededSecretKey` now has as its elements a scalar and a hash prefix. * Various functions that took `&[u8]` now take `&[u8; N]`. * We no longer need a wrapper for older versions of rand. There is a single test in tor-keymgr that does not pass. I've marked it as ignore for now, in hopes that @gabi-250 can help me figure it out. This closes #808. There are several changes I want to make before we merge, however. They are marked with TODO DALEK. 2023-05-18T15:00:43Z Nick Mathewson nickm@torproject.org 2023-05-18T15:00:43Z urn:sha1:dcec7ca2dc6563e5277f5e913759ab19884e2e69 Per #798, we want to make sure that we never pass around an `ed25519::SecretKey`; only an `ed25519::Keypair` (or `ExpandedKeypair`). This is because, when you're computing an ed25519 signature, you have to use the public key as one of your inputs, and if you ever use a mismatched public key you are vulnerable to a nonce reuse attack. (For more info see https://moderncrypto.org/mail-archive/curves/2020/001012.html ) 2023-01-27T13:27:47Z Nick Mathewson nickm@torproject.org 2023-01-27T12:49:39Z urn:sha1:bf04641c6818cb2c87c6ed9cf463a5710f8919d2 This warning kind of snuck up on us! (See #748) For now, let's disable it. (I've cleaned it up in a couple of examples, since those are meant to be more idiomatic and user-facing.) Closes #748. 2023-01-20T13:06:30Z Nick Mathewson nickm@torproject.org 2023-01-19T19:50:07Z urn:sha1:889206cde4ef29d7d10bda546f8ad518eb09c290 This is in lieu of upgrading to the latest base64 crate, which has a different API from the old one. Since we have to migrate either way, we might as well use base64ct everywhere. I don't think that most of these cases _require_ constant-time base64, but it won't hurt. 2022-09-22T16:45:52Z Ian Jackson iwj@torproject.org 2022-09-22T16:45:52Z urn:sha1:a773a753b3220dc41f61a9ac89abb5c6e1558f9e Fix nightly clippy See merge request tpo/core/arti!729