mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks 2023-01-27T13:27:47Z 2023-01-27T13:27:47Z Nick Mathewson nickm@torproject.org 2023-01-27T12:49:39Z urn:sha1:bf04641c6818cb2c87c6ed9cf463a5710f8919d2 This warning kind of snuck up on us! (See #748) For now, let's disable it. (I've cleaned it up in a couple of examples, since those are meant to be more idiomatic and user-facing.) Closes #748. 2022-09-20T13:13:31Z Nick Mathewson nickm@torproject.org 2022-09-20T13:13:31Z urn:sha1:657914f7787a0ac5bdaad8c15d41a91425e1c8cf There are some places in the protocol where we have an all-zero RSA identity that does not truly represent a key, but rather represents an absent or unknown key. For these, it's better to use `RsaIdentity::is_zero` instead of manually checking for a set of zero bytes: it expresses the intent better, and ensures that the operation is constant-time. I am deliberately not introducing a more general IsZero trait here, or implementing is_zero for anything else: This is the only one we seem to need right now. We can generalize it later if we have to. 2022-06-02T18:56:42Z Nick Mathewson nickm@torproject.org 2022-06-02T17:31:43Z urn:sha1:967ea67b7dfc158f29cf449eb09bac89acdee46b This only affects uses of thread_rng(), and affects them all more or less indiscriminately. One test does not work with ARTI_TEST_PRNG=deterministic; the next commit will fix it. 2022-04-25T17:06:26Z Nick Mathewson nickm@torproject.org 2022-04-25T16:40:33Z urn:sha1:2f6bc6bdc431fa36de70a167eea777dcf3f60bf2 Remove all `use` statements for `TryFrom` and `TryInto`. These are now redundant in Rust 2021. 2022-03-04T13:55:34Z Nick Mathewson nickm@torproject.org 2022-03-04T13:55:34Z urn:sha1:b6452b481215ce0963123630234b01be0c440092 We perform this operation in a bunch of places, and most of them use hex::decode(). That's not great, since hex::decode() has to do heap allocation. This implementation uses hex::decode_to_slice(), which should be faster. (In the future we might choose to use one of the faster hex implementations, but I'm hoping that this change will be sufficient to get hex decoding out of our profiles.) Part of #377. 2022-03-02T16:25:01Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-03-02T16:21:29Z urn:sha1:7a4369e240948cdc27c7ad03f40a42efbc52b95b I'm going to change the code that does this, so add a test first to check the output doesn't change. At some point we should have more RSA tests. 2021-08-27T13:53:09Z Nick Mathewson nickm@torproject.org 2021-08-27T13:53:09Z urn:sha1:557a0ff40b3731d4690767de27010bbeff08777d This will cause some pain for now, but now is really the best time to do this kind of thing.