mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.0 2026-06-25T12:10:52Z 2026-06-25T12:10:52Z Clara Engler cve@cve.cx 2026-06-25T12:10:52Z urn:sha1:6f8fa9cf188a31dd8faf63f7173b1bb2f008e2ae ExpandedKeypair already implements Ed25519SigningKey, so there is no reason to not implement Ed25519PublicKey on it. 2026-06-10T17:17:33Z Nick Mathewson nickm@torproject.org 2026-06-10T16:35:32Z urn:sha1:21ea6f773b627e1991e54422448d6731bf3df5ce This eliminates some string slicing. 2026-06-09T16:02:36Z Clara Engler cve@cve.cx 2026-06-09T16:00:38Z urn:sha1:d0af4abbd7b371f1eade609202a730cd9a1c21d3 This commit adds #[allow(clippy::string_slice)] to all functions in the code where string slices are used, alongside a TODO comment. We do this add the function header to have it consistent, as things like expression based allow's are still experimental. 2026-06-09T15:36:01Z Clara Engler cve@cve.cx 2026-06-09T15:36:01Z urn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97 This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit. 2026-05-12T20:55:43Z Wesley Aptekar-Cassels me@wesleyac.com 2026-05-07T20:06:21Z urn:sha1:a18167928901d8c88cd1cdd87346de8ad1ee42a2 When the circ-padding feature is enabled, we use maybenot, which does not yet support rand 0.10. In the meantime, enabling this feature pulls in rand 0.9. This is not ideal, but should be okay as a temporary situation. This also replaces the use of ReseedingRng (which was removed in 0.10) with the reseeding_rng crate. This is somewhat less performant, but it should be okay. 2026-05-07T12:08:01Z Nick Mathewson nickm@torproject.org 2026-05-04T13:45:55Z urn:sha1:0c4ed480afc9a96b37db9630c7ee3185a69fa999 2026-04-28T14:14:42Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-28T14:14:42Z urn:sha1:544ae6e376c80814a162b83f9196a29b65b31781 It is harmless to derive Deftly without doing more. Do that, rather than cfg'ing the use of derive_deftly::Deftly. 2026-04-23T14:53:37Z Clara Engler cve@cve.cx 2026-04-23T14:51:17Z urn:sha1:5f0cc69966dcd6f30719a516739d2670e86e645f This commit adds .to_bytes() to RsaIdentity which is similar to .as_bytes() except that it returns the RsaIdentity as a byte array. We are going to need this at a few places in tor-dirserver. The naming was inspired from x25519-dalek which has similar .as_bytes() and .to_bytes() methods. Besides, copying 20 bytes shall be okay and it avoids having to write ugly try_into() constructs. 2026-02-16T15:22:24Z Gabriela Moldovan gabi@torproject.org 2026-02-09T11:49:02Z urn:sha1:ade1d59e8e44c93b6ee447b72a2948a9652ec44e `clippy::collapsible_if` started triggering after bumping the MSRV to 1.88. Since this triggers from a lot of places, and since there even are a couple of instances where we explicitly allow `clippy::collapsible_ifs`, I've opened #2342 for deciding what to do about it. 2026-02-10T18:41:01Z Steven Engler opara@torproject.org 2026-02-10T18:37:55Z urn:sha1:330ac4ac555116c69b565cccc6eecbd8dcd43515 This is intended to be analogous to `RsaIdentity::from_hex()`. I've found myself wanting this a few times, and it makes it easy to grab a `master-key-ed25519` from the consensus and paste it into the code without needing to do extra conversions.