mirrors/arti.git/crates/tor-llcrypto/src, branch arti-v1.4.3mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.32025-03-24T19:11:48Zllcrypto: Document some design choices from CautiousRng.2025-03-24T19:11:48ZNick Mathewsonnickm@torproject.org2025-03-24T16:39:41Zurn:sha1:d3ba62b6e9bfa9d138042a062838c65d7fa3ab0fUse an EntropicRng trait to enforce key generation rules.2025-03-24T19:11:48ZNick Mathewsonnickm@torproject.org2025-03-20T15:09:08Zurn:sha1:8a33afe155e9bd29d9302b4b44dd5843d00866db
We want to require that whenever we generate a key that's persistent
(stored in KeyMgr), it's going to be made from a stronger-than-usual
Rng. This trait helps us enforce that.
We also add a FakeEntropicRng struct to use for testing.
Note that this turned up a case that we'd missed, which required
an internal change in tor-hsservice.
Use CautiousRng for keys going into the KeyMgr.2025-03-24T19:10:21ZNick Mathewsonnickm@torproject.org2025-03-20T14:51:44Zurn:sha1:71ec7a3c6e563c4107ff62ea003794c6a31e45a6llcrypto: new CautiousRng for constructing long-lived keys2025-03-24T19:10:21ZNick Mathewsonnickm@torproject.org2025-03-20T14:26:56Zurn:sha1:ee7c15868e916bc7dbbd26e707077c452dd5d452
This Rng combines inputs from several sources,
including OsRng, to minimize the likelihood
of falling to a vulnerability in any particular one.
squash! Upgrade rand dependency to 0.9.2025-03-18T16:09:44ZNick Mathewsonnickm@torproject.org2025-03-18T14:47:35Zurn:sha1:895bc807f106e359d35522a3ad5f288ba6cf6a9c
- The Rng::gen() functions have been renamed to Rng::random().
llcrypto: add an rng compatibility shim for dalek-crypto2025-03-18T16:09:44ZNick Mathewsonnickm@torproject.org2025-03-18T13:24:41Zurn:sha1:9e4de6cbfe5cef6076b89f7a94a5232d47b980dd
dalek-cryptography is still on rand 0.8, so we need a compatibility
shim for the Rng.
Fortunately, since we merged interface-abstraction-of-the-daleks
(!2868), we no longer need to propagate this compatibility layer
throughout our codebase.
Wrap ed25519-dalek types.2025-03-18T12:45:28ZNick Mathewsonnickm@torproject.org2025-03-17T18:31:42Zurn:sha1:d50e945a5286d89d75892878ff3aa9ed7ebed1f7
With this change, we'll no longer need to expose the types from
dalek-cryptography as part of our API, and we'll have more freedom
to switch ed25519 implementations, or to upgrade to a newer
`rand` ahead of their schedule.
Unlike with x25519-dalek, I had to tweak the API a bit: There's no
way to get a &PublicKey out of a Keypair now, and implementing the
old ed25519-dalek traits seemed unnecessary.
Wrap x25519-dalek types.2025-03-17T18:40:17ZNick Mathewsonnickm@torproject.org2025-03-17T18:31:42Zurn:sha1:6f5ad88ec515c95a632ed2c582d4ca61d89247af
With this change, we'll no longer need to expose the types from
dalek-cryptography as part of our API, and we'll have more freedom
to switch curve25519 implementations, or to upgrade to a newer
`rand` ahead of their schedule.
clippy: deny `mod_module_files`2025-01-06T23:09:41ZSteven Engleropara@torproject.org2025-01-06T23:02:49Zurn:sha1:252a3a803b2db65792db5bd51dee8950d8557e0d
Denies 'mod.rs' files for consistency.
https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
add_warnings, *: Allow clippy::needless_lifetimes2024-12-03T14:27:26ZNick Mathewsonnickm@torproject.org2024-12-03T14:15:50Zurn:sha1:64cc3f2ed3eea0b7c5cc89ae07cbdadfdc1646fb
In 1.83, this warning triggers on many of our crates.
We're thinking of fixing them all, but for now,
we're going to disable the warning.
This is part of #1765.