mirrors/arti.git/crates/tor-llcrypto/src/pk/rsa.rs, branch arti-v1.1.3mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.32023-01-20T13:06:30ZUpgrade to latest rsa crate.2023-01-20T13:06:30ZNick Mathewsonnickm@torproject.org2023-01-19T20:22:18Zurn:sha1:131775bf3639c1f49d41ca19f2efc3162c316bf7llcrypto: fix a comment.2023-01-06T18:03:50ZNick Mathewsonnickm@torproject.org2022-12-20T17:01:37Zurn:sha1:7d38bbd829bcbb1f708417d365e509630a233b69
This described the wrong type of key.
llcrypto: clarify meaning of "Identity".2023-01-06T18:03:47ZNick Mathewsonnickm@torproject.org2022-12-20T16:57:30Zurn:sha1:e7c87372e2a3e1b13be29e908374d5d2219ddacd
The `Ed25519Identity` and `RsaIdentity` types are not precisely
always used as relay identifiers: they are more generally used as
_key_ identifiers.
This will become relevant as `RsaIdentity` is used for authority
keys (as in authorities' VoterInfo blocks), and as `Ed25519Identity`
is used as the identifier behind an onion service key.
Add a new "CtByteArray" type, and use it in Id types.2023-01-05T17:34:14ZNick Mathewsonnickm@torproject.org2023-01-05T17:34:14Zurn:sha1:9d3f19fd385bc35ee9d821f9e15df2498564516b
This type provides a common implementation for types that are
implemented as arrays of bytes that should only be compared
with constant-time comparisons.
llcrypto: Make key id types Redactable.2022-11-28T13:01:10ZNick Mathewsonnickm@torproject.org2022-11-21T19:25:30Zurn:sha1:8d36fa9996a2ca76e18513003ea77eea6146114aFix a bunch of "needless borrow" warnings on nightly2022-11-18T15:12:05ZNick Mathewsonnickm@torproject.org2022-11-18T15:12:05Zurn:sha1:d51162e55b19036528b4fafc1d4b15c8d9d23a04
It looks like, despite a few false starts, they've got this warning
right; there weren't any false positives.
Upgrade rsa to 0.7. Closes #613.2022-11-10T16:04:20ZNick Mathewsonnickm@torproject.org2022-10-28T17:38:42Zurn:sha1:e19ff0ec2129c5bd19deb5cbf61b52c0648e6553Add a new constant-time is_zero() check for RsaIdentity2022-09-20T13:13:31ZNick Mathewsonnickm@torproject.org2022-09-20T13:13:31Zurn:sha1:657914f7787a0ac5bdaad8c15d41a91425e1c8cf
There are some places in the protocol where we have an all-zero RSA
identity that does not truly represent a key, but rather represents
an absent or unknown key. For these, it's better to use
`RsaIdentity::is_zero` instead of manually checking for a set of
zero bytes: it expresses the intent better, and ensures that the
operation is constant-time.
I am deliberately not introducing a more general IsZero trait here,
or implementing is_zero for anything else: This is the only one we
seem to need right now. We can generalize it later if we have to.
Stop deriving Zeroize for RsaIdentity.2022-08-01T16:27:53ZNick Mathewsonnickm@torproject.org2022-08-01T16:23:59Zurn:sha1:dd0a83925c7cfb944155be57327f73891cb2f52a
These are not secret.
Update `rsa` dependency (and use `x25519-dalek` prerelease)2022-07-06T13:57:45Zetator@eta.st2022-07-05T10:57:10Zurn:sha1:c2e2da5dc35b2e0aa4cc17865ec4d14c725558c7
- arti#448 and arti!607 highlight an issue with upgrading `rsa`: namely,
the `x25519-dalek` version previously used has a hard dependency on
`zeroize` 1.3, which creates a dependency conflict.
- However, `x25519-dalek` version `2.0.0-pre.1` relaxes this dependency.
Reviewing the changelogs, it doesn't look like that version is
substantially different from the current one at all, so it should be
safe to use despite the "prerelease" tag.
- The new `x25519-dalek` version also bumps `rand_core`, which means we
don't have to use the RNG compat wrapper in `tor-llcrypto` as much.
closes arti#448