mirrors/arti.git/crates/tor-llcrypto/src/pk/keymanip.rs, branch arti-v2.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.02026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
Remove unnecessary `doc(cfg(...))` attributes2025-12-05T02:40:50ZNeel Chauhanneel@neelc.org2025-11-01T23:25:20Zurn:sha1:26b40cb08b6b715ee80e2b9084810e07512a85c6
Fixes part of #2193.
(Edits from nickm: I selected the cases here that I could verify
were correct from immediate context.)
Edited-by: Nick Mathewson <nickm@torproject.org>
Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
Wrap ed25519-dalek types.2025-03-18T12:45:28ZNick Mathewsonnickm@torproject.org2025-03-17T18:31:42Zurn:sha1:d50e945a5286d89d75892878ff3aa9ed7ebed1f7
With this change, we'll no longer need to expose the types from
dalek-cryptography as part of our API, and we'll have more freedom
to switch ed25519 implementations, or to upgrade to a newer
`rand` ahead of their schedule.
Unlike with x25519-dalek, I had to tweak the API a bit: There's no
way to get a &PublicKey out of a Keypair now, and implementing the
old ed25519-dalek traits seemed unnecessary.
keymanip: Make blind_pubkey exist unconditionally2024-08-21T14:41:11ZNick Mathewsonnickm@torproject.org2024-08-21T13:50:27Zurn:sha1:eabea0226da288aaa2cfbf7a64eeccbc3fd5c8a1
Now it exists unconditionally so that we can have our assertion for
public key consistency happen unconditionally. (Blinding secret
keys is not remotely in the critical path, so I'm not concerned
about the critical path.)
From a suggestion from Gabi on !2341.
keymanip: Use doc(cfg(...)) in place of "Availability" sections2024-08-21T14:41:11ZNick Mathewsonnickm@torproject.org2024-08-21T12:45:32Zurn:sha1:309e8220332a9e5f81954a621d8a02f0daf7aa00llcrypto: Make `blind_keypair` build without hsv3-client.2024-08-21T14:41:11ZNick Mathewsonnickm@torproject.org2024-08-14T13:06:02Zurn:sha1:34cd96eca10c321a44cea39f596161545853c3b6
The `blind_keypair` function should only call `blind_pubkey` when it
is present.
Also, fix the documentation: blind_keypair is a hsv3-service function,
not a hsv3-client function.
Closes #1504.
Run maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320cclippy: consequential rustfmt2024-01-02T15:04:18ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-02T12:49:55Zurn:sha1:1ba7e8a78f21b5e1c26c87d12e7a77ebb3a8949dclippy: Use infallible calls2024-01-02T13:56:22ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-02T12:48:56Zurn:sha1:0ce386a24bd5b0490aee28345f90c7ac956a844d
Resolves clippy complaints about needless fallible conversions.