mirrors/arti.git/crates/tor-llcrypto/src/pk/keymanip.rs, branch arti-v1.2.2mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.22024-03-13T16:30:53ZRun maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320cclippy: consequential rustfmt2024-01-02T15:04:18ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-02T12:49:55Zurn:sha1:1ba7e8a78f21b5e1c26c87d12e7a77ebb3a8949dclippy: Use infallible calls2024-01-02T13:56:22ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-02T12:48:56Zurn:sha1:0ce386a24bd5b0490aee28345f90c7ac956a844d
Resolves clippy complaints about needless fallible conversions.
Fix a rustdoc error.2023-11-30T00:51:07ZNick Mathewsonnickm@torproject.org2023-11-30T00:51:07Zurn:sha1:0b5aba974e6fe4abe7ae23ff0f619b7eb5d2175dllcrypto: Undo internal ed25519-dalek renamings in keymanip.rs2023-11-29T16:27:15ZNick Mathewsonnickm@torproject.org2023-11-29T16:27:15Zurn:sha1:f50f0780bd151f75677168e48012829f8f1e936fllcrypto: Remove redundant re-exports in keymanip.2023-11-29T16:17:17ZNick Mathewsonnickm@torproject.org2023-11-29T16:17:17Zurn:sha1:af75131bcfca2c89d200fa13704be1f49a9fd94d
(These types were all already re-exported from pk::ed25519.)
llcrypto: Remove ExpandedSecretKey export.2023-11-29T16:11:39ZNick Mathewsonnickm@torproject.org2023-11-29T16:11:39Zurn:sha1:4470b378f69caf42dcf81277b9883247e2c62103
This type was part of `hazmat`, and was no longer necessary anywhere
in our codebase. (It had one remaining user, which was easy enough
to remove.) By removing it, we remove the opportunity for using an
unescorted ed25519 private key.
Deprecate convert_ed25519_to_curve25519_private as unused2023-11-29T15:56:28ZNick Mathewsonnickm@torproject.org2023-11-29T15:56:28Zurn:sha1:5ad6dfdda0bf7f1698340b772ac08d7ce87d91d6Remove RngCompatExt.2023-11-29T15:55:04ZNick Mathewsonnickm@torproject.org2023-11-29T15:49:26Zurn:sha1:7fb24cb69da537ac04ab2dae80997c6d481622ef
This code was needed with the old version of dalek-cryptography,
which wasn't compatible with up-to-date versions of the `rand`
crate(s). But now that we've upgraded, we can drop this.
(We could have left it around and deprecated it, but we are already
making a breaking change to tor-llcrypto by upgrading
dalek-cryptography.)
Convert to the latest versions of dalek-cryptography2023-11-29T15:34:58ZNick Mathewsonnickm@torproject.org2023-11-21T15:58:29Zurn:sha1:98037a2c788bd901679139178d25f855324637f3
The main changes that we have to adjust for are as follows:
* In x25519-dalek:
* `StaticSecret` is now behind a feature.
* `StaticSecret::new` is deprecated in favor of
`StaticSecret::random_from_rng`.
* StaticSecret no longer does its own clamping.
* In ed25519-dalek:
* `SecretKey` has (in effect) been renamed to `SigningKey`. The name
`SecretKey` is now an alias for `[u8; 32]`.
* `SigningKey` is effectively a keypair, since it contains a
public key as well.
* `PublicKey` has been renamed to `VerifyingKey`.
* The functions to extract a signing key and verifying key have
been renamed as you might expect.
* `ExpandedSecretKey` has been moved to `hasmat` and no longer
implements `sign`.
* `ExpanededSecretKey` now has as its elements a scalar and a hash
prefix.
* Various functions that took `&[u8]` now take `&[u8; N]`.
* We no longer need a wrapper for older versions of rand.
There is a single test in tor-keymgr that does not pass. I've
marked it as ignore for now, in hopes that @gabi-250 can help me
figure it out.
This closes #808. There are several changes I want to make before
we merge, however. They are marked with TODO DALEK.