mirrors/arti.git/crates/tor-llcrypto/src/pk/keymanip.rs, branch arti-v1.1.5mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.52023-05-18T15:00:43Zllcrypto: Don't take or return "unescorted" ed25519 keys.2023-05-18T15:00:43ZNick Mathewsonnickm@torproject.org2023-05-18T15:00:43Zurn:sha1:dcec7ca2dc6563e5277f5e913759ab19884e2e69
Per #798, we want to make sure that we never pass around an
`ed25519::SecretKey`; only an `ed25519::Keypair` (or
`ExpandedKeypair`). This is because, when you're computing an
ed25519 signature, you have to use the public key as one of your
inputs, and if you ever use a mismatched public key you are
vulnerable to a nonce reuse attack.
(For more info see
https://moderncrypto.org/mail-archive/curves/2020/001012.html )
Use non-deprecated *Secret::random_from_rng.2023-05-13T20:52:23ZNick Mathewsonnickm@torproject.org2023-05-13T20:52:23Zurn:sha1:bfda3082d454e1ce6cbf62974b82395fff254c80
The `new` function is deprecated in x25519-dalek 2.0.0-rc.2
tor-llcrypto: key blinding: Use consistent terminology2023-03-28T11:47:12ZIan Jacksonijackson@chiark.greenend.org.uk2023-03-28T11:32:27Zurn:sha1:def291dcb5c6b657296886e95a2b4fa3717b466a
Unhelpfully, the spec uses the variable name `h` and the phrase
"blinding factor" for both the unclamped and clamped value. The
clamped value is internal to the algorithm.
In our code:
* Don't ever use the word "parameter" or variable name `param`.
This doesn't appear in the spec anywhere.
* Use `h` for the unclamped blinding factor, and `blinding_factor` for the
clamped blinding factor.
* Rename `blinding_factor` function to `clamp_blinding_factor`, since
in the spec's terminology it takes an (unclamped) "blinding factor"
and returns a (clamped) "blinding factor".
* State explicitly what thing in the spec the `h` parameters are.
tor-llcrypto: Tolerate some warnings (fmt)2023-01-20T17:29:45ZIan Jacksonijackson@chiark.greenend.org.uk2023-01-20T17:29:36Zurn:sha1:5c76bca69218487244663a23f1976b333a9bc6a0tor-llcrypto: Tolerate some warnings2023-01-20T16:37:31ZIan Jacksonijackson@chiark.greenend.org.uk2023-01-20T16:36:25Zurn:sha1:bd21d232799b8c6dba638ff95e0f42d7b25226a3
Without this,
cargo +stable clippy -p tor-netdoc --all-features
produces warnings.
llcrypto: Implement secret-key blinding.2023-01-06T17:02:49ZNick Mathewsonnickm@torproject.org2023-01-06T17:02:49Zurn:sha1:306e72c56660b71b395734d4ef606d315a23147a
Closes #719.
Due to a difference between ed25519-dalek and ed25519-donna,
converting these secret keys directly to public keys does not work.
I've documented this in a "Limitations" section.
Merge remote-tracking branch 'origin/mr/610'2022-07-05T13:10:10ZNick Mathewsonnickm@torproject.org2022-07-05T13:10:10Zurn:sha1:56f931e8e138ca8167db477f1514dca64fee42e0Fixed typo in convert_curve25519_to_ed25519_private comments2022-06-29T16:52:59ZRichard Pospeselrichard@torproject.org2022-06-29T16:52:59Zurn:sha1:61119d500470f876166646a0a9fdfcb7cc0e6533tor-llcrypto: style fixes on BlindingError2022-06-22T12:47:18ZNick Mathewsonnickm@torproject.org2022-06-22T12:47:18Zurn:sha1:f6d6ac7fe93b73a4914b747b106ea69885a89c39Use testing_rng() in tests throughout our crates.2022-06-02T18:56:42ZNick Mathewsonnickm@torproject.org2022-06-02T17:31:43Zurn:sha1:967ea67b7dfc158f29cf449eb09bac89acdee46b
This only affects uses of thread_rng(), and affects them all more or
less indiscriminately. One test does not work with
ARTI_TEST_PRNG=deterministic; the next commit will fix it.