mirrors/arti.git/crates/tor-llcrypto/src/pk/keymanip.rs, branch arti-v1.1.3 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.3 2023-03-28T11:47:12Z tor-llcrypto: key blinding: Use consistent terminology 2023-03-28T11:47:12Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-03-28T11:32:27Z urn:sha1:def291dcb5c6b657296886e95a2b4fa3717b466a Unhelpfully, the spec uses the variable name `h` and the phrase "blinding factor" for both the unclamped and clamped value. The clamped value is internal to the algorithm. In our code: * Don't ever use the word "parameter" or variable name `param`. This doesn't appear in the spec anywhere. * Use `h` for the unclamped blinding factor, and `blinding_factor` for the clamped blinding factor. * Rename `blinding_factor` function to `clamp_blinding_factor`, since in the spec's terminology it takes an (unclamped) "blinding factor" and returns a (clamped) "blinding factor". * State explicitly what thing in the spec the `h` parameters are. tor-llcrypto: Tolerate some warnings (fmt) 2023-01-20T17:29:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-01-20T17:29:36Z urn:sha1:5c76bca69218487244663a23f1976b333a9bc6a0 tor-llcrypto: Tolerate some warnings 2023-01-20T16:37:31Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-01-20T16:36:25Z urn:sha1:bd21d232799b8c6dba638ff95e0f42d7b25226a3 Without this, cargo +stable clippy -p tor-netdoc --all-features produces warnings. llcrypto: Implement secret-key blinding. 2023-01-06T17:02:49Z Nick Mathewson nickm@torproject.org 2023-01-06T17:02:49Z urn:sha1:306e72c56660b71b395734d4ef606d315a23147a Closes #719. Due to a difference between ed25519-dalek and ed25519-donna, converting these secret keys directly to public keys does not work. I've documented this in a "Limitations" section. Merge remote-tracking branch 'origin/mr/610' 2022-07-05T13:10:10Z Nick Mathewson nickm@torproject.org 2022-07-05T13:10:10Z urn:sha1:56f931e8e138ca8167db477f1514dca64fee42e0 Fixed typo in convert_curve25519_to_ed25519_private comments 2022-06-29T16:52:59Z Richard Pospesel richard@torproject.org 2022-06-29T16:52:59Z urn:sha1:61119d500470f876166646a0a9fdfcb7cc0e6533 tor-llcrypto: style fixes on BlindingError 2022-06-22T12:47:18Z Nick Mathewson nickm@torproject.org 2022-06-22T12:47:18Z urn:sha1:f6d6ac7fe93b73a4914b747b106ea69885a89c39 Use testing_rng() in tests throughout our crates. 2022-06-02T18:56:42Z Nick Mathewson nickm@torproject.org 2022-06-02T17:31:43Z urn:sha1:967ea67b7dfc158f29cf449eb09bac89acdee46b This only affects uses of thread_rng(), and affects them all more or less indiscriminately. One test does not work with ARTI_TEST_PRNG=deterministic; the next commit will fix it. squash! Bump every crate's edition to 2021. 2022-04-25T17:06:26Z Nick Mathewson nickm@torproject.org 2022-04-25T16:40:33Z urn:sha1:2f6bc6bdc431fa36de70a167eea777dcf3f60bf2 Remove all `use` statements for `TryFrom` and `TryInto`. These are now redundant in Rust 2021. Remove a XXXX comment in tor-llcrypto. 2021-12-08T16:32:28Z Nick Mathewson nickm@torproject.org 2021-12-08T16:32:28Z urn:sha1:a596797660b84e6ec8d7209a637c94f973014a94 This comment was about an unspecified string; the issue of specifying the string is now torspec!55.