mirrors/arti.git/crates/tor-linkspec/src/ls.rs, branch arti-v2.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.02026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
Some HasMemoryCost impls in tor-linkspec2024-10-02T18:11:26ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-26T20:18:43Zurn:sha1:213fef3fbc73f45064e0ff9ec0c6737cf7a4ccddtor_bytes: Rename new_truncated_for_test to new_incomplete_for_test (fmt)2024-09-12T11:48:39ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T15:52:29Zurn:sha1:8c2c1170daa9b1fc4a13177edd3881e934b99899tor_bytes: Rename new_truncated_for_test to new_incomplete_for_test2024-09-12T11:48:38ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T15:51:40Zurn:sha1:5314741adecad01014a069c4f0ed5018e0f6c207
No semver implications since this wasn't in the last release.
tor-bytes: Add a Reader constructor for use in tests2024-09-11T13:19:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T12:04:46Zurn:sha1:98e563764b428e4f1aa87dc34e5fa6b5cf296938
We could call from_possibly_incomplete_slice in these, but that's
confusing and distracting.
Here we add this constructor, and document it (in terms of the
constructor to come), and change the call sites.
No functional change. Doing this now will prevent unwanted changes to
test behaviours when we change the behaviour of Readers made by
Reader::from_slice.
Change tor_bytes::Readable name to `b` in many places2024-09-11T12:22:39ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-10T14:34:52Zurn:sha1:040db873ed95f9d24ed9d0162d75b9c8a11e457f
The codebase uses `r` sometimes and `b` at other times.
Making this consistent makes widespread changes easier, and is
clearer for humans.
I think `b` is better than `r` because `r` might be "return".
It is indeed used that way in a couple of places in reader.rs, even.
I haven't changed *everywhere*, just Readable impls (where `r` is
particularly likely to be "return value") and occurrences in
tor-bytes.
No functional change.
Introduce and use tor_bytes::Error::new_truncated_for_test2024-09-10T09:10:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-05T15:39:31Zurn:sha1:38494a86c7146d2bbc7573b9346ad24341491779
This is going to want to do something more complicated (as described
in the docs).
In this commit we change all the tests that are expecting Truncated
errors. That reduces noise in the next commit.
tor-linkspec: reading tests: Use assert_eq2024-09-10T09:10:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-05T15:04:58Zurn:sha1:952c192a995590fb0924800d7c1ed83f7d018db5
Error::Truncated is going to become more complicated, and anyway it
would be nice to print the values if the test fails.
Error is PartialEq now. (Maybe it wasn't when this was written?)
Run maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320c