mirrors/arti.git/crates/tor-linkspec/src/lib.rs, branch arti-v1.0.1

Mark all bridge and pt features as experimental for now.

2022-09-29T14:59:19Z

Also, document the features. Closes #588.

pt: Introduce PtTransportName

2022-09-27T11:44:23Z

The config parsing wants this. Also there are some anomalies in the types here that ought to be tidied up.

Rename various Transport* types to Pt*.

2022-09-23T18:08:53Z

This clarifies that the types apply to pluggable transports only, and not (typically) to the default plain-old-TCP transport.

Add a HasChanMethods trait, with a bunch of open TODO questions.

2022-09-23T18:08:24Z

We'll need to sort these out as we implement pluggable transports.

New data types to describe transport targets.

2022-09-23T18:08:24Z

I've tried to name and structure these for consistency, and comment reasonably well. We'll still probably want to make changes.

Add TransportTargetAddr as the target address for a PT-using channel

2022-09-23T18:08:24Z

As with `TransportId`, this type only gets complicated when `pt-client` is enabled: it's meant to stay simple for relays and non-PT-using clients.

Create an API for TransportId

2022-09-23T13:55:33Z

enable doc_auto_cfg feature on every crate when documenting for docs.rs

2022-08-24T16:22:41Z

Final (?) API revisions for tor-linkspec

2022-08-10T14:39:37Z

With this change, each individual identity type becomes optional. The functions that expose them unconditionally are now in a "legacy" trait that only some downstream types are expected to implement. There are new convenience APIs in HasRelayIds: * to return Option<&keytype>, * to see if one identity-set contains another. This commit will break several downstream crates! For the reviewer's convenience, I will put the fixes for those crates into a series of squash! commits on this one. tor-netdir ---------- Revise tor-netdir to accept optional identities. This required some caveats and workarounds about the cases where we have to deal with a key type that the tor-netdir code does not currently recognize at all. If we start to add more identity types in the future, we may well want more internal indices in this code. tor-proto --------- In order to make tor-proto support optional identities, there were fewer changes than I thought. Some "check" functions needed to start looking at "all the ids we want" rather than at "the two known IDs"; they also needed to accommodate that case where we don't have an ID that we demand. This change will also help with bridges, since we want to be able to connect to a bridge without knowing all of its IDs up front. The protocol currently _requires_ the two current ID types in some places. To deal with that, I added a new `MissingId` error. I also removed a couple of unconditional identity accessors for chanmgr; code should use `target().identity(...)` instead. tor-chanmgr ----------- This is an incomplete conversion: it does not at all handle channel targets without Ed25519 identities yet. It still uses those identities to index its internal map from identity to channel; but it gives a new `MissingId` error type if it's given a channel target that doesn't have one. We'll want to revise the map type again down the road when we implement bridges, but I'd rather not step on the channel-padding work in progress right now. tor-guardmgr ------------ This change is mostly a matter of constructing owned identity types more sensibly, rather than unwrapping them directly. There are some places marked with TODOs where we still depend on particular identity types, because of how the directory protocol works. This will need revisiting when we add bridge support here. tor-circmgr ----------- These changes are just relatively simple API changes in the tests.

Introduce a RelayIdSet and use it in place of HashSet.

2022-08-10T14:39:36Z

This makes lookups a little more efficient. I do with that HashSet just supported this use-case, but for now this seems our best option.