mirrors/arti.git/crates/tor-linkspec/src/ids.rs, branch main

tor-linkspec: RelayIdType: Clarify display vs display_id

2026-07-15T10:40:08Z

Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4196#note_3433090

tor-linkspec: Un-explode and tidy some derive lists

2026-07-01T18:15:59Z

rustfmt likes this IMO-awful layout for derives. We can force it to let us manually break the line, if we use //, and then it stays put. No functional change.

tor-linkspec: Sort out indentation in new macro template

2026-07-01T18:15:59Z

Pure whitespace change. Review with, eg, git diff -w.

tor-linkspec: PartialEq: use deftly, not an ad-hoc macro_rules

2026-07-01T18:15:59Z

This gets rid of the matcher, and the need to invoke it.

tor-linkspec: PartialEq: change variable names

2026-07-01T18:15:59Z

Change $var to $vname, and $type to $IDENTITY. These are the names used in the deftly template. This will make the next commit almost a no-op.

tor-linkspec: PartialEq: simplify PartialEq for RelayId

2026-07-01T18:15:59Z

We can just refer to the PartialEq for RelayIdRef, which is macro-generated just above, replacing this copy-pasted matches.

tor-linkspec: Use deftly for RelayIdId and RelayIdRef impls

2026-07-01T18:15:59Z

This removes quite a lot of in-detail copy-paste. The lone `}` is being moved, bringing the code we're changing within the scope of the template.

tor-linkspec: Minimal deftly for RelayIdId and RelayIdRef

2026-07-01T18:15:59Z

Derive the two types. We end up moving the display strings from direct attributes directed to derive_more, to deftly attributes. Indentation is rather odd now: we ought to indent the macro body. We'll sort that out at the end. No functional change.

tor-linkspec: Move PartialEq impls

2026-07-01T18:13:22Z

Pure code motion. We want to move this to where a bigger macro is going to be, so that it can be part of it. Code motion only, review with --color-moved.

maint: Run maint/add_warning to deny string slices

2026-06-09T15:36:01Z

This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit.