mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.7 2024-09-03T08:09:02Z 2024-09-03T08:09:02Z Dimitris Apostolou dimitris.apostolou@icloud.com 2024-09-03T08:09:02Z urn:sha1:676f913463b7d84f34dd6101b99d03ef79cf57ad 2024-08-08T10:06:48Z Gabriela Moldovan gabi@torproject.org 2024-08-08T09:48:33Z urn:sha1:e060d5bb70d3cdd0ffbb7cbbfeff3b38ed02bd26 `fs-mistrust` always maps `io::ErrorKind::NotFound` to `fs_mistrust::Error::NotFound`, so these `io::ErrorKind::NotFound` branches were unreachable. 2024-08-08T10:06:48Z Gabriela Moldovan gabi@torproject.org 2024-08-07T15:31:10Z urn:sha1:cfa23cf3cf6e5c448a5f35ecfaffb111cc81a01b We now use `CheckedDir::metadata()` to check if the path exists and is of the correct type. 2024-08-08T10:01:03Z Gabriela Moldovan gabi@torproject.org 2024-08-01T17:25:15Z urn:sha1:f05ed2f43a0b1007227deffdb5dda70bb8047a5f 2024-08-08T10:01:03Z Gabriela Moldovan gabi@torproject.org 2024-08-01T17:20:19Z urn:sha1:19d734f04803c4186d466c1be110f962644ae4a6 2024-08-08T10:01:03Z Gabriela Moldovan gabi@torproject.org 2024-08-01T17:19:00Z urn:sha1:0fbe8a88ed5e65f921ba009165fbb92f4705bb97 2024-08-08T09:53:29Z Gabriela Moldovan gabi@torproject.org 2024-07-30T11:27:59Z urn:sha1:619b6ca22b8b42c106b34402a6a6b049808271a4 This makes `rel_path` return a `RelKeyPath` instead of a `PathBuf` to prevent the accidental misuse of relative key paths (like the one from #1492). Closes #1494 2024-07-30T14:20:24Z Gabriela Moldovan gabi@torproject.org 2024-07-30T14:14:47Z urn:sha1:761d33b6ef9413bc05b4d48104f597f69ebc9305 2024-07-28T21:48:35Z Nick Mathewson nickm@torproject.org 2024-07-28T21:34:18Z urn:sha1:1b6394cec9653937b404b93ed510e90b2eff9ae7 This warning complains when we say `where T: SomeTrait + ?Sized` when `SomeTrait` is inherently Sized. 2024-07-17T15:55:13Z Gabriela Moldovan gabi@torproject.org 2024-07-17T15:13:46Z urn:sha1:a48804f9a0770ab54a117a35c6ffdf4df9387950 This fixes a bug in `ArtiNativeKeystore`'s `Keystore::contains()` implementation: previously, it called Path::exists() on the relative path (built by concatenating the key specifier and the extension), so unless your current directory happened to be the root of the keystore, `contains()` would always return `false`. `KeyMgr::generate` uses `Keystore::contains()` under the hood, so it was affected by this bug too: if called `overwrite = false`, it would misbehave and overwrite any existing keys. Internally, we call `KeyMgr::generate` in a couple of places: * `tor-hsservice/src/lib.rs`, to generate the `hsid` if it doesn't already exist. This callsite is not affected by the bug, because `KeyMgr::generate` is only called if `KeyMgr::get` returns `None` * `tor-hsservice/src/ipt_mgr.rs`, to generate `KS_hss_ntor` and `KS_hs_ipt_sid` keys for intro point establishment. This callsite is also not affected (because it too calls `get()` before attempting to `generate()`) The bug affects any downstream users that use `KeyMgr::generate` with a key manager backed by `ArtiNativeKeystore`. ------ `KeyMgr::get_or_generate` is not affected, even though it calls `Keymgr::generate` (it performs a separate extra check before calling `generate()`). (Both suffer from a known TOCTOU race, but that's a separate matter.) As an aside, I'd like to somehow unify `KeyMgr::get_or_generate` and `KeyMgr::get` (I've had some attempts in the past but ended up abandoning them because the result was more unergonomic than the existing APIs). Part of #1492