mirrors/arti.git/crates/tor-keymgr/src, branch arti-v1.2.4mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.42024-05-15T11:00:12Ztor-keymgr: Add script for generating test key files.2024-05-15T11:00:12ZGabriela Moldovangabi@torproject.org2024-05-01T12:57:00Zurn:sha1:2828a5ab2e667bd3d8c8333fd26999a999d3a0d7
`tor-keymgr/testdata` contains a bunch of OpenSSH keys used for testing.
I meant to share the script I generated them with, but somehow never got
around to it.
Note: the OpenSSH keys generated by this script are going to look
slightly different than the ones that are checked into the repo. This is
because some of those original key files were generated ad-hoc (I
manually modified them a while ago, but I forgot exactly how
tor-keymgr: Fix nightly warnings.2024-05-09T16:18:23ZGabriela Moldovangabi@torproject.org2024-05-09T16:18:23Zurn:sha1:a9a520f23e793c215d575a33242c22c28e3403cc
This is a follow-up from !2131
Merge branch 'keymgr-ephemeral-refactor' into 'main'2024-05-09T16:13:53Zgabi-250gabi@torproject.org2024-05-09T16:13:53Zurn:sha1:cab19524b9c3f2de9b5d2cfabf0371b098075a86
tor-keymgr: Refactor code shared between ArtiNativeKeystore and ArtiEphemeralKeystore
Closes #1362 and #1367
See merge request tpo/core/arti!2131Revert "tor-keymgr: Fix now-failing test."2024-05-08T18:08:24ZGabriela Moldovangabi@torproject.org2024-05-08T18:07:36Zurn:sha1:04d527bbd66545e6b0178951c4d041287cdb12bb
This reverts commit 9ea35caeb1ed23fd029627d04819debc41d85c77.
tor-keymgr: Validate the KeyType when inserting into the ephemeral keystore.2024-05-08T18:08:24ZGabriela Moldovangabi@torproject.org2024-05-08T18:06:22Zurn:sha1:4401bfb74d0dde20fd8e3ce2fb5b4cb4d2182147
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2131#note_3028014
tor-keymgr: Add function for extracting the KeyType of an ssh key.2024-05-08T17:32:11ZGabriela Moldovangabi@torproject.org2024-05-07T14:17:01Zurn:sha1:453bf8c6c52198f6f51b8190ca42b4432d8f3fd6tor-keymgr: Fix newly failing tests (fmt).2024-05-08T10:01:30ZGabriela Moldovangabi@torproject.org2024-05-08T10:01:30Zurn:sha1:d9ae165f3b9e852db134649c6ea53399dab6e125tor-keymgr: Fix newly failing tests.2024-05-08T09:54:39ZGabriela Moldovangabi@torproject.org2024-05-08T09:53:25Zurn:sha1:c92a51f83752a7ca80690af84da8943c3a514c71
This updates the keymgr tests to be slightly more robust.
These tests attach some metadata to each key, such as the "nickname" of
the key (which only exists for testing purposes), whether the key was
auto-generated, and the keystore ID of the keystore from which the key
was retrieved.
Previously, the metadata was encoded in the key "material" itself (the
test "keys" were actually just `String`s with a hacky `EncodableKey`
implementation that abused the "encrypted" variant of `KeypairData`).
This was only possible because we had access to the key internals
(through `SshKeyData::Public`/`SshKeyData::Private`), but since the
internals are inaccessible now, the tests need to be updated.
tor-keymgr: Make SshKeyData an opaque type.2024-05-07T18:43:35ZGabriela Moldovangabi@torproject.org2024-05-07T18:40:34Zurn:sha1:dfb63f8eb8453ae417d2381859cfe7bd213651e5
This helps prevent external users from creating `SshKeyData` out of
unsupported types of `ssh_key::public::KeyData` and
`ssh_key::private::KeypairData`.
tor-keymgr: Do not make SshKeyData infallibly convertible from KeyData/KeypairData.2024-05-07T18:30:54ZGabriela Moldovangabi@torproject.org2024-05-07T15:43:06Zurn:sha1:38233357f3bda9d5b87eabb7ebba38796409742a