mirrors/arti.git/crates/tor-keymgr/src, branch arti-v1.1.6 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.6 2023-06-30T11:30:45Z Merge branch 'arti-path-bug' into 'main' 2023-06-30T11:30:45Z gabi-250 gabi@torproject.org 2023-06-30T11:30:45Z urn:sha1:8c1e96a22cdce0c2c27f9a78dbc615ff66642763 keymgr: Allow periods in ArtiPath and ArtiPathComponent. See merge request tpo/core/arti!1358 keymgr: Update ArtiPath and ArtiPathComponent docs. 2023-06-30T10:49:05Z Gabriela Moldovan gabi@torproject.org 2023-06-29T23:04:40Z urn:sha1:35e063702f68655906157f3ae1e2335d0f4b4d77 The docs were lying, we actually support UTF-8 paths (though we might later decide to restrict the charset further). keymgr: Allow periods in ArtiPath and ArtiPathComponent. 2023-06-30T10:48:27Z Gabriela Moldovan gabi@torproject.org 2023-06-29T23:01:26Z urn:sha1:474f273b6cd360b1a11f81d72acfed1d6302bf15 The `ArtiPath` of a client auth key contains the `HsId` of the onion Since the `HsId` contains a `.onion` component, let's allow `.` for now. In the future, we may want to update the code (and keystore structure) to strip away the `.onion` part before building the `ArtiPath`. keymgr: Downgrade "TODO hs" to "TODO HSS" 2023-06-30T10:16:28Z Gabriela Moldovan gabi@torproject.org 2023-06-30T10:16:28Z urn:sha1:90183368a2a6aebe739dbc5d70b4215ba10e615f This TODO doesn't need to block the release. keymgr: Rename KeyStore to Keystore globally. 2023-06-29T21:46:15Z Gabriela Moldovan gabi@torproject.org 2023-06-29T21:46:15Z urn:sha1:36606a66ddca9abd1595d13c9397bc812bf24cb5 We've been capitalizing the "s" in "KeyStore" inconsistently. This `s/KeyStore/Keystore/g` across the codebase. keymgr: Remove unstable ErrorKind, use internal! for ArtiPath errors. 2023-06-29T18:28:22Z Gabriela Moldovan gabi@torproject.org 2023-06-29T17:47:29Z urn:sha1:c9f4ef010f858256217504354efaae2ecdf39f6d keymgr: Validate the individual ArtiPahtComponents of ArtiPath. 2023-06-29T18:28:22Z Gabriela Moldovan gabi@torproject.org 2023-06-29T16:02:45Z urn:sha1:f81d16ff9b9b1ff1303ede2479133374e4fde980 This also implicitly forbids leading and trailing slashes in an `ArtiPath`. keymgr: Rephrase ArtiPath docs. 2023-06-29T18:28:22Z Gabriela Moldovan gabi@torproject.org 2023-06-29T15:57:07Z urn:sha1:0ebb002de82fd093707784430eb77d99693c1380 This updates the docs with Diziet's suggested doc improvements. keymgr: Remove ArtiPath normalization, introduce additional restrictions. 2023-06-29T18:28:22Z Gabriela Moldovan gabi@torproject.org 2023-06-28T15:18:03Z urn:sha1:b5e190d05dadfb7edf2a346ab285b5d3d1860d61 keymgr: Document how ArtiPath validation is actually supposed to work. 2023-06-29T18:28:22Z Gabriela Moldovan gabi@torproject.org 2023-06-28T14:51:54Z urn:sha1:d59c3bdea908b6b73a40e462603aae98bd3dfaed