mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.11 2023-11-30T14:43:15Z 2023-11-30T14:43:15Z Ian Jackson iwj@torproject.org 2023-11-30T14:43:15Z urn:sha1:d5b450081e8490613f0d700317a40c2ce5eedbcb tor-keymgr: Remove unnecessary impls for KeystoreCorruptionError. See merge request tpo/core/arti!1779 2023-11-29T18:38:24Z Gabriela Moldovan gabi@torproject.org 2023-11-29T18:37:12Z urn:sha1:cfed96e3bf054b41638d89f14133630ed699162c These impl only exist because they were needed back when we didn't have the `tor_keymgr::Error` enum and all errors _had_ to implement `KeystoreError`. They are not used or required anymore, so let's remove them. 2023-11-29T17:10:18Z Nick Mathewson nickm@torproject.org 2023-11-29T17:10:18Z urn:sha1:adc3209c6bef9cc03542c31c22c0f308938e1643 With this change, we no longer expose the ExpandedSecretKey unescorted, which makes it harder to misuse the API. 2023-11-29T15:55:04Z Nick Mathewson nickm@torproject.org 2023-11-29T15:49:26Z urn:sha1:7fb24cb69da537ac04ab2dae80997c6d481622ef This code was needed with the old version of dalek-cryptography, which wasn't compatible with up-to-date versions of the `rand` crate(s). But now that we've upgraded, we can drop this. (We could have left it around and deprecated it, but we are already making a breaking change to tor-llcrypto by upgrading dalek-cryptography.) 2023-11-29T15:34:58Z Nick Mathewson nickm@torproject.org 2023-11-21T15:58:29Z urn:sha1:98037a2c788bd901679139178d25f855324637f3 The main changes that we have to adjust for are as follows: * In x25519-dalek: * `StaticSecret` is now behind a feature. * `StaticSecret::new` is deprecated in favor of `StaticSecret::random_from_rng`. * StaticSecret no longer does its own clamping. * In ed25519-dalek: * `SecretKey` has (in effect) been renamed to `SigningKey`. The name `SecretKey` is now an alias for `[u8; 32]`. * `SigningKey` is effectively a keypair, since it contains a public key as well. * `PublicKey` has been renamed to `VerifyingKey`. * The functions to extract a signing key and verifying key have been renamed as you might expect. * `ExpandedSecretKey` has been moved to `hasmat` and no longer implements `sign`. * `ExpanededSecretKey` now has as its elements a scalar and a hash prefix. * Various functions that took `&[u8]` now take `&[u8; N]`. * We no longer need a wrapper for older versions of rand. There is a single test in tor-keymgr that does not pass. I've marked it as ignore for now, in hopes that @gabi-250 can help me figure it out. This closes #808. There are several changes I want to make before we merge, however. They are marked with TODO DALEK. 2023-11-28T22:03:30Z Gabriela Moldovan gabi@torproject.org 2023-11-28T14:08:53Z urn:sha1:f63c07954a3344032704aa91ca035aa3861d6779 `ArtiNativeKeystore::list` now returns an error if the parent directory of any of its keys doesn't pass the `CheckedDir::read_dir` validation. Part of #1117 2023-11-28T22:03:30Z Gabriela Moldovan gabi@torproject.org 2023-11-28T13:28:38Z urn:sha1:052aefafe39c2b7bced2ad848fe839c67a913679 This updates `ArtiNativeKeystore` to use the new `remove_file` API from arti!1759. Part of #1117 2023-11-28T12:29:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-11-28T12:29:01Z urn:sha1:74ec98af5fb02d1f5d7d63adeed4fb393b3f5abd 2023-11-28T12:12:09Z gabi-250 gabi@torproject.org 2023-11-28T12:12:09Z urn:sha1:009533057f57b3c8e5e81a70314f2ead97db63e4 tor-keymgr: Derive Builder for KeyMgr. Closes #1114 See merge request tpo/core/arti!1760 2023-11-28T11:32:12Z Gabriela Moldovan gabi@torproject.org 2023-11-28T11:32:12Z urn:sha1:8a48d5be9d18d544d8c6508f74ac98c2e2259fb9 Eventually these will need to be auto-generated, but that is not possible right now. Context: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1760#note_2969841