mirrors/arti.git/crates/tor-keymgr/src/test_utils.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
keymgr: Use unquoted keypair_specifier in tests2026-04-16T09:22:54ZGabriela Moldovangabi@torproject.org2026-04-15T13:07:09Zurn:sha1:6d7e6a278a0b0a9822a198d2933bf2ea8a46897ckeymgr: Update cert tests2026-03-17T12:22:01ZGabriela Moldovangabi@torproject.org2026-03-16T18:58:43Zurn:sha1:dcff6a762cd90844376bf5456b02a96fde74ae12
This is needed now that `get_or_generate_key_and_cert()`
uses the keypair specifier when generating the subject key.
Without this the cert retrieval tests fail because
`get_or_generate_key_and_cert()` now requires the subject key specifier
to have an associated keypair specifier ("KeyCertificateSpecifier has no
keypair specifier for the subject key?").
Note that even with this patch, the `get_cert_entry()` test still fails
because of a bug in the `get_*()` family of functions. This will be
fixed in a future commit.
keymgr: Generate test cert specifiers using d-d2026-03-12T14:56:39ZGabriela Moldovangabi@torproject.org2026-03-09T18:24:50Zurn:sha1:43fa4cb7b2e24022b3cb7d9f39b93e4ed0e9aedb
This will enable us to test against other keymgr APIs (e.g.
`list_matching()`), which require some extra trait impls that get
generated for free by our new `CertSpecifier` macro.
keymgr: Abolish KeyCertificateSpecifier::signing_key_specifier() (fmt)2026-03-12T14:56:35ZGabriela Moldovangabi@torproject.org2026-02-23T18:35:16Zurn:sha1:26d68cb7eb87acba11086cc6e856061efd92fb9akeymgr: Abolish KeyCertificateSpecifier::signing_key_specifier()2026-03-12T14:56:35ZGabriela Moldovangabi@torproject.org2026-02-27T16:19:34Zurn:sha1:29b8feb559114245e95a9de561b504e3e387fcd4
We need to be able to parse KeyPaths into KeyCertificateSpecifier,
and we can't do that if the signing key is part of the cert specifier
(because the signing key doesn't get encoded in the key path, unlike the
subject key, which does)
Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
tor-keymgr: test_utils: TestSpecifier::path_prefix: Drop method2025-03-26T18:08:11Zplaybahnplabanroy69@gmail.com2025-03-26T17:44:57Zurn:sha1:fbfeede629f1b1d326befc77e9cabc8575e86db5
Part of #1455
tor-keymgr: Fix clippy errors2025-03-26T18:08:11Zplaybahnplabanroy69@gmail.com2025-03-22T16:31:27Zurn:sha1:e155cde05e568dceaf36d070bcd7a5489d7fe707