mirrors/arti.git/crates/tor-keymgr/src/mgr.rs, branch arti-v1.4.1

tor-keymgr: Use ParsedEd25519Cert when decoding certs.

2025-01-13T19:29:19Z

This helps us get rid of our uses of `KeyUnknownCert`. Needed because `KeyUnknownCert` can't readily be converted back to `EncodedEd25519Cert` (while `ParsedEd25519Cert` *can* -- see the `certs` module from `tor-relay-crypto`).

tor-keymgr: Fix cert handling tests.

2025-01-13T19:26:51Z

This updates and reenables the cert management tests. Part of #1768

tor-keymgr: Use Ed25519Cert::decode to parse the certs.

2025-01-13T19:25:57Z

tor-key-forge: Split out ItemType as a separate trait.

2025-01-13T19:22:36Z

This is necessary because `ParsedCert`s will not be `EncodableItem`s. This is because we cannot (and don't want to) write certificates that have not yet been validated to the keystore. They do need to be retrievable from the keystore though, so we also change `ErasedKey` to be `Box` instead.

tor-key-forge: Distinguish between parsed certs and encodable certs.

2025-01-13T19:21:45Z

We need two different types to represent * certs that have been parsed, but not yet validated (`KeyUnknownCert`) * newly generated encodable certs (`EncodedEd25519Cert`) Currently, we don't use `KeyUnknownCert` anywhere, and instead use `EncodedEd25519Cert` to represent "parsed" but not-yet-validated certs. This approach is wrong and relies on a broken (no-op) `EncodedEd25519Cert::from_bytes` implementation. A future commit will address this problem by replacing `EncodedEd25519Cert::from_bytes` with `Ed25519Cert::decode` to actually parse the cert upon retrieving it from the keystore.

tor-keymgr: Replace from_encodable_cert with validation function.

2025-01-13T19:21:45Z

In practice, we won't be able to obtain an `ToEncodableCert` type from an `EncodableItem` cert without validating it first, so we need to collapse `validate` into `from_encodable_cert`. Part of #1768

fix: fix typos

2025-01-06T20:36:37Z

tor-keymgr: Replace internal error with keystore corruption error.

2024-12-04T16:43:31Z

This replaces a placeholder error with a concrete `KeystoreCorruptionError` variant.

tor-keymgr: Add tests for the new cert mgmt functions.

2024-12-04T16:43:31Z

tor-keymgr: s/TestKey/TestItem in tests.

2024-12-04T16:43:31Z

We're about to reuse TestKey as our test key "certificate", so let's preemptively rename it to something more fitting.