mirrors/arti.git/crates/tor-keymgr/src/mgr.rs, branch arti-v1.1.6

keymgr: Rename KeyStore to Keystore globally.

2023-06-29T21:46:15Z

We've been capitalizing the "s" in "KeyStore" inconsistently. This `s/KeyStore/Keystore/g` across the codebase.

keymgr: Downgrade "TODO hs" to "TODO HSS".

2023-06-28T15:44:06Z

These TODOs can be deferred for now: we're not declaring the keymgr APIs stable until we add support for hidden services.

keymgr: Replace Error with Box.

2023-06-26T12:16:03Z

Part of #901

keymgr: Downgrade 2 "TODO hs" to "TODO HSS".

2023-06-22T10:28:24Z

keymgr: Remove Error::NotFound, update KeyMgr, KeyStore APIs.

2023-06-21T15:00:30Z

This removes the `NotFound` `tor_keymgr::Error` variant. Since `KeyMgr` and `KeyStore` users will need to be able to distinguish between "not found" errors and other I/O errors, this also changes the return types of the `get()` and `remove()` functions of `KeyStore` and `KeyMgr`, which now return `Ok(None)` instead of `Error::NotFound`. This makes the `KeyStore` API consistent with `KeyMgr::get`, which already has a return type of `Result>` (rather than `Result`). This also prepares us for #901, which will make key store errors opaque. Without this change: * we'd have to create a `struct NotFoundError;` error type. Its `HasKind` impl would need to return a new `ErrorKind::KeyStoreErrorNotFound` `ErrorKind` variant * callers would have to match the `error_kind()` of the error to figure out whether the key simply can't be found (`ErrorKind::KeyStoreErrorNotFound`), or if something went wrong (any other `ErrorKind`). Given the above, I think `Result>` makes for a more ergonomic API. Part of #901

keymgr: Defer key bundle support until "Basic Service" milestone.

2023-06-20T10:36:04Z

We don't really need "key bundles" for the client keys.

keymgr, arti-client: KeyMgr should return Ok(None) if the key is not found.

2023-06-15T17:16:34Z

This simplifies usage quite a bit and will enable us to implement a dummy `KeyMgr` that doesn't depend on the error types from tor-keymgr (which will replace the "real" `KeyMgr` if the keymgr feature is disabled).

keymgr: Introduce ToEncodableKey to simplify lookups.

2023-06-15T17:15:30Z

This means `KeyMgr` users don't need to specify the underlying key type (e.g. `ed25519::Keypair`) when retrieving keys. Instead, they can just specify the type required (as long as it implements `ToEncodableKey`), e.g. `HsClientIntroAuthKeypair`.

keymgr: Add key manager implementation stub.

2023-06-15T17:15:30Z