mirrors/arti.git/crates/tor-keymgr/src/lib.rs, branch ios-sqlite-hacksmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks2023-08-16T09:44:14Ztor-keymgr: Re-export ssh-key.2023-08-16T09:44:14ZGabriela Moldovangabi@torproject.org2023-08-15T00:39:56Zurn:sha1:c8999f230bd00ba92d8482fe76e99547ccb98d46
The `KeypairData` type from [ssh-key] at some point leaked into the
keymgr API (via the `EncodableKey` trait). Instead of re-exporting just
`KeypairData`, let's re-export the entire `ssh_key` crate
(`EncodableKey` implementors would need additional types from `ssh_key`
to construct a `KeypairData` object anyway).
[ssh-key]: https://crates.io/crates/ssh-key
Run add_warnings on all files.2023-08-04T11:45:04ZNick Mathewsonnickm@torproject.org2023-08-04T11:45:04Zurn:sha1:cec6d0ce33b4b5cebbce57f55faec83397e9c953keymgr: Replace EncodableKey::to_bytes() with SSH-specific function.2023-08-02T13:13:18ZGabriela Moldovangabi@torproject.org2023-08-02T13:09:56Zurn:sha1:e70be1353c5e200304d1adfd5413d2608e7ac511
The `EncodableKey::to_bytes` function didn't make much sense, because
not all keys have a canonical byte representation.
This commit replaces `EncodableKey::to_bytes` with
`EncodableKey::as_ssh_keypair_data`. In the future, `EncodableKey` will
grow functions for encoding keys in other storage formats too.
Closes #965
keymgr: Add function for generating EncodableKeys.2023-07-24T12:17:23ZGabriela Moldovangabi@torproject.org2023-07-24T11:01:59Zurn:sha1:9c326ced816ab4bf9e3e7380f5caa6a6cb05a784keymgr: Use KeystoreId instead of a static string.2023-07-21T11:36:29ZGabriela Moldovangabi@torproject.org2023-07-21T11:20:46Zurn:sha1:96e59cb97fda894fbd432390ab95141b5b1ceee1keymgr: Add a newtype for keystore identifiers.2023-07-21T11:36:22ZGabriela Moldovangabi@torproject.org2023-07-21T10:35:09Zurn:sha1:32083cbd513721504cb76f323993043df367de20keymgr: Remove unused KeystoreSelector::All variant.2023-07-21T11:36:13ZGabriela Moldovangabi@torproject.org2023-07-21T10:58:28Zurn:sha1:d48cc2ca6bc36055911f9ff0e33b797acb10bf1a
This also removes the corresponding
`KeyMgrError::UnsupportedKeystoreSelector` error, because it's not
needed anymore.
keymgr: Add type for specifying which keystore to access.2023-07-20T18:24:12ZGabriela Moldovangabi@torproject.org2023-07-19T15:44:34Zurn:sha1:cf038fb772b956fdb06887232de02960358d4919tor-keymgr: Add ArtiNativeKeystoreConfig.2023-07-13T11:13:59ZGabriela Moldovangabi@torproject.org2023-07-12T18:07:13Zurn:sha1:d8299e8d2f3874f28f4b39893f75fc7be6962091
Previously, the keystore config consisted of a single field in
`StorageConfig`, which encoded 2 bits of information: whether the
keystore is enabled, and its root directory:
```
[storage]
# use this path, fail if compiled out
# keystore = "/path/to/arti/keystore"
#
# use default path, fail if compiled out
# keystore = true
#
# disable
# keystore = false
```
This commit adds `ArtiNativeKeystoreConfig`, which will replace the
multi-purpose `keystore` field. The new config will look like this:
```
#[storage.keystore]
# Whether the keystore is enabled.
#
# If the `keymgr` feature is enabled and this option is:
# * set to false, we will ignore the configured keystore path.
# * set to "auto", the configured keystore, or the default keystore, if the
# keystore path is not specified, will be used
# * set to true, the configured keystore, or the default keystore, if the
# keystore path is not specified, will be used
#
# If the `keymgr` feature is disabled and this option is:
# * set to false, we will ignore the configured keystore path.
# * set to "auto", we will ignore the configured keystore path.
#
# Setting this option to true when the `keymgr` feature is disabled is a
# configuration error.
#enabled = "auto"
# The root directory of the arti keystore
#path = "${ARTI_LOCAL_DATA}/keystore"
```
While `ArtiNativeKeystoreConfig` currently only has 2 fields, `enabled`
and `path`, future versions of the keystore might require additional
config options.
Run maint/add_warning to actually apply new lint allows2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T11:19:32Zurn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0