mirrors/arti.git/crates/tor-keymgr/src/keystore, branch arti-v2.5.0

arti, keymgr: s/IDEA/TODO

2026-06-17T16:18:26Z

It's better to use "TODO" like we do in the rest of Arti, because otherwise this has a chance of being forgotten (because nobody really greps for "IDEA").

arti: subcommands: keys: Rework output of keys list

2026-06-17T16:17:59Z

maint: Run maint/add_warning to deny string slices

2026-06-09T15:36:01Z

This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit.

keymgr: Update tests to stop using RawKeystoreEntry (fmt)

2026-05-18T15:07:50Z

keymgr: Update tests to stop using RawKeystoreEntry

2026-05-18T15:07:50Z

`RawKeystoreEntry` no longer exists, so these tests need to be updated.

keymgr: Remove RawKeystoreEntry (fmt)

2026-05-18T15:07:50Z

keymgr: Remove RawKeystoreEntry

2026-05-18T15:07:50Z

I think this adds unnecessary indirection, and it's a bit confusing to have two separate keystore entry types (we have `KeystoreEntry` too). This type exists just to server as a wrapper over the `RawEntryId` of an unrecognized keystore entry, and the `KeystoreId` of the keystore it was found in. This commit folds `RawKeystoreEntry` into `UnrecognizedEntry`, which was previously a thin wrapper over `RawKeystoreEntry`.

tor-cert: Ed25519CertBuilder: do builder fn rename

2026-04-29T16:49:21Z

Change all call sites. This completes the rename.

keymgr: Fix ephemeral keystore cert encoding bug (fmt)

2026-04-08T09:35:02Z

keymgr: Fix ephemeral keystore cert encoding bug

2026-04-08T09:19:38Z

This fixes a bug that was causing the ephemeral keystore to retrieve certs in a format that couldn't be handled by the `KeyMgr`. This caused all certificate retrievals from `EphemeralKeystore` done via the `KeyMgr` to fail with an internal error. For context, the only supported cert type is `TorEd25519Cert`, which is a pre-encoded certificate (i.e. a type wrapper over a `Vec`). These certificates are stored as-is by the Arti native keystore (the bytes are written to a file on disk). When retrieving a `TorEd25519Cert`, the Arti keystore uses `parse_certificate_erased()` to parse the cert into a `ParsedEd25519Cert` before returning it as a type-erased `ErasedKey`. This works as intended with the `KeyMgr` retrieval and downcasting logic, which expects the certificate to be returned in the `ParsedCert` format specified in the `ToEncodableCert` implementation. Before this change, the ephemeral keystore, on the other hand, did not play well with the `KeyMgr` when it came to cert retrieval: it would incorrectly store the `KeystoreItem` as-is, and retrieve it as an `ErasedKey` using the `ErasedKey::into_erased()` implementation. This would then cause the `KeyMgr` to fail to downcast the `ErasedKey` to the correct type (because the returned erased item was of a different type than `ParsedCert`). This commit also removes `KeystoreItem::into_erased()`, which was a footgun (because certificates are not actually supposed to be retrieved in the format returned by `CertData::into_erased()`).