mirrors/arti.git/crates/tor-keymgr/src/keystore/arti.rs, branch arti-v2.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.02026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
keymgr: Update tests to stop using RawKeystoreEntry (fmt)2026-05-18T15:07:50ZGabriela Moldovangabi@torproject.org2026-05-18T13:44:47Zurn:sha1:adb4a7f37802dd7103f603183736d1554902afdbkeymgr: Update tests to stop using RawKeystoreEntry2026-05-18T15:07:50ZGabriela Moldovangabi@torproject.org2026-05-18T13:40:59Zurn:sha1:990fba43560351210275dab971285d9de038bf8a
`RawKeystoreEntry` no longer exists, so these tests need to be updated.
keymgr: Remove RawKeystoreEntry (fmt)2026-05-18T15:07:50ZGabriela Moldovangabi@torproject.org2026-05-18T13:28:45Zurn:sha1:4673b7a95bd023ac8d84046462a3790ec3785893keymgr: Remove RawKeystoreEntry2026-05-18T15:07:50ZGabriela Moldovangabi@torproject.org2026-05-18T13:24:46Zurn:sha1:2cfba1e031f5721cda583d95c03223e517c11612
I think this adds unnecessary indirection, and it's a bit confusing to
have two separate keystore entry types (we have `KeystoreEntry` too).
This type exists just to server as a wrapper over the `RawEntryId` of an
unrecognized keystore entry, and the `KeystoreId` of the keystore it was
found in.
This commit folds `RawKeystoreEntry` into `UnrecognizedEntry`, which was
previously a thin wrapper over `RawKeystoreEntry`.
tor-cert: Ed25519CertBuilder: do builder fn rename2026-04-29T16:49:21ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-28T09:58:04Zurn:sha1:d90b703d0c4bc4ffb9068fb5c25fc78e72743961
Change all call sites.
This completes the rename.
tor-keymgr: migrate to web-time-compat.2026-03-26T19:20:16ZNick Mathewsonnickm@torproject.org2026-03-26T14:04:29Zurn:sha1:734837268cd5a6c9b177b8daa11aa38b33500dacFix typos2026-03-24T16:04:08ZTobias Stoeckmanntobias@stoeckmann.org2026-03-24T16:04:08Zurn:sha1:1fb2b8dd4aee7c943ce90d6631be473f2a296fe6
Typos found with codespell
Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
clippy: fix `clippy::implicit_clone` errors2025-08-11T15:18:41ZSteven Engleropara@torproject.org2025-08-11T15:18:16Zurn:sha1:691177eae9f0d3117220f7927237fbf9fafc79e6
```text
error: implicitly cloning a `String` by calling `to_string` on its dereferenced type
--> crates/tor-config/src/lib.rs:109:32
|
109 | V::String(_, s) => s.to_string(),
| ^^^^^^^^^^^^^ help: consider using: `s.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone
note: the lint level is defined here
--> crates/tor-config/src/lib.rs:20:9
|
20 | #![deny(clippy::implicit_clone)]
| ^^^^^^^^^^^^^^^^^^^^^^
```