mirrors/arti.git/crates/tor-keymgr/src/keystore/arti.rs, branch arti-v1.3.0

tor-keymgr: Add tests for CTorClientKeystore.

2024-10-08T13:25:17Z

tor-keymgr: Move assert_found helper to test_utils.

2024-10-08T13:25:17Z

This moves `assert_found` out of the `keystore::arti::test` so we can reuse it for testing other keystore implementations too.

tor-keymgr: Rename Filesystem variant to Io for clarity (fmt).

2024-10-08T13:23:17Z

tor-keymgr: Rename Filesystem variant to Io for clarity.

2024-10-08T13:23:17Z

The `FilesystemError::Filesystem` variant was actually just for IO errors.

tor-keymgr: Refactor common fs errors into a separate error enum.

2024-10-08T13:23:17Z

This will be reused by other on-disk key stores (such as the C Tor ones we're about to add). I recommend reviewing this commit using `git diff --color-moved=zebra --ignore-space-change`

tor-keymgr: Rename RelKeyPath::new to RelKeyPath::arti.

2024-10-08T13:23:17Z

We're about to add a separate constructor for CTor paths.

tor-keymgr: Move the checked_op utils out of the arti module.

2024-10-08T13:23:17Z

We are about to use this for the ctor keystore implementation too.

tor-keymgr: Reimagine CTorPath as an enum.

2024-10-08T13:23:17Z

C Tor's client restricted discovery keys don't have the service hsid encoded in the filename (the hsid of the service each key is associated with is encoded in contents of the key file). This means that given a key specifier like `HsClientDescEncKeypairSpecifier` (which is a wrapper over an HsId), we can't actually compute the relative path of the key in its `KeySpecifier::ctor_path()` implementation. To do so we would need to access the keystore to figure out which path contains the requested HsId, which we can't (and shouldn't!) do from within the `KeySpecifier` impl. This suggests the String newtype (representing a relative path) we previously had is not a good abstraction for `CTorPath`s. Moreover, `CTorPath` are static (they don't have dynamic components like `ArtiPath`), so it makes more sense to model `CTorPath` as an enum. The new `CTorPath::ClientHsDescEncKey(HsId)` variant will be used to instruct the C Tor client keystore to find the file that contains the specified `HsId`, while the `Service` variant will be used for hidden service keys.

Rename tor-keys crate to tor-key-forge

2024-09-04T18:26:37Z

Signed-off-by: David Goulet

tor-keymgr: Use tor-keys crate and remove dead code

2024-09-04T18:25:55Z

Everything copied in the previous commits to tor-keys is now removed and tor-keys crate is used accross the code. Minor changes to tor-keys to accomodate this change. Part of #1137 Signed-off-by: David Goulet