mirrors/arti.git/crates/tor-keymgr/src/keystore.rs, branch arti-v1.1.7

keymgr: Make Keystore::generate() return a Result.

2023-07-27T10:03:06Z

keymgr: Add function for generating EncodableKeys.

2023-07-24T12:17:23Z

keymgr: Add a Keystore::contains accessor.

2023-07-24T12:17:05Z

Fix typos

2023-07-22T07:10:34Z

keymgr: Use KeystoreId instead of a static string.

2023-07-21T11:36:29Z

keymgr: Add EncodableKey::to_bytes for encoding keys.

2023-07-20T18:25:04Z

We'll need this to implement `Keystore::insert`.

keymgr: Remove unimplemented/unnecessary has_key_bundle function.

2023-07-20T18:24:44Z

The concept of a "key bundle" would introduce a lot of complexity while providing little to no gain. Some context: ``` Originally, "key bundles" were meant to be the answer to the question "which keystore should insert place keys in?": https://gitlab.torproject.org/tpo/core/arti/-/blob/36606a66ddca9abd1595d13c9397bc812bf24cb5/crates/tor-keymgr/src/mgr.rs#L60-69 However, I'm not so sure anymore that "key bundles" are the answer. I don't think there is any way we can "guess" where a key should go. When inserting/generating a new key, we should either: always write to the same, primary key store, OR require the user to be explicit about which key store the new key should go in (by assigning an ID to each key store and expecting the user to provide it when inserting/generating new keys) I prefer the latter option, because it provides more flexibility, which we're going to need when implementing the key management CLI (which I think should allow users to generate keys anywhere they want, e.g. arti keymgr generate --keystore hsm ...) ``` For more details, see the discussion on #903. Closes #903

keymgr: Add an `id` function to `Keystore`.

2023-07-20T18:24:05Z

This will enable the `KeyMgr` to look up `Keystore`s by ID (which is a requirement for disambiguating the semantics of `insert`, which currently tries to "guess" which keystore it should be using).

keymgr: Use Box instead of Box.

2023-07-10T13:41:30Z

Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1337#note_2917701 This will make it harder to accidentally return the wrong value from `Keystore::get` (the returned value is now at least guaranteed to implement `EncodableKey`). Closes #937

keymgr: Explain why the TODO regarding EncodableKey can't be addressed.

2023-07-05T21:21:47Z