mirrors/arti.git/crates/tor-keymgr/src/dummy.rs, branch arti-v1.4.2mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.22024-11-20T14:32:30Ztor-keymgr: Remove now-unnecessary clippy allows from dummy impl.2024-11-20T14:32:30ZGabriela Moldovangabi@torproject.org2024-11-20T14:19:20Zurn:sha1:d03cbd746678fc325eafdb2b5972fb8bfa8d5f87tor-keymgr: Allow dead code in dummy KeyMgr.2024-11-20T14:21:45ZGabriela Moldovangabi@torproject.org2024-11-20T14:17:12Zurn:sha1:4165ef3ee7661a87e1dd3ef7018fc950560dbc8d
The fields are never read but need to be present in order for the
dummy `KeyMgrBuilder` to have the same interface as the real one.
(We could of course manually implement the builder, or let the dummy
`KeyMgrBuilder` impl diverge from the real one, but for now let's leave
this as-is and simply mark the fields as unused).
tor-keymgr: Remove unused dummy error type.2024-11-20T14:21:45ZGabriela Moldovangabi@torproject.org2024-11-20T14:15:20Zurn:sha1:5d5879bf00f052ebae1dc982153dacf87833102d
We no longer have any dummy keymgr operations that return an error,
so this error type is unused.
tor-keymgr: Remove unused imports from dummy module.2024-11-20T14:21:45ZGabriela Moldovangabi@torproject.org2024-11-20T14:14:14Zurn:sha1:a5eb8e679bbec91d4f5a02603b35cf2102115c55tor-keymgr: Remove unused dummy KeyType.2024-11-20T14:21:45ZGabriela Moldovangabi@torproject.org2024-11-20T14:13:45Zurn:sha1:2a9e804fdadfc7378e15853b9b1736ef5770f882
This is not used anywhere (or exported publicly).
tor-keymgr: Say that another option is to enable keymgr unconditionally.2024-11-14T13:00:05ZGabriela Moldovangabi@torproject.org2024-11-14T13:00:05Zurn:sha1:8facb23eed024369fa18d0f4f962c640ff6eeac2
This commit applies Diziet's suggestion from
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2631#note_3130234
tor-keymgr: Remove a couple of dummy KeyMgr functions.2024-11-14T11:15:43ZGabriela Moldovangabi@torproject.org2024-11-14T11:13:54Zurn:sha1:c9f55e8df5364acef6b7bf21a3426d81d0b745e0
These are not actually needed anywhere.
In fact, it's a bad idea to have them in the first place (see the
comment from the dummy `KeyMgr` impl block).
tor-keymgr: Explain why the dummy keymgr is missing some functions.2024-11-14T11:13:41ZGabriela Moldovangabi@torproject.org2024-11-14T11:02:46Zurn:sha1:582e43a117919e389e2fb556c7f0fa6002c42dff
This is based on a recent discussion with @Diziet on IRC.
For the full context, see the chat log attached to the ticket.
Closes #1732
tor-keymgr: Rename the primary keystore for clarity.2024-09-23T13:17:49ZGabriela Moldovangabi@torproject.org2024-09-20T10:20:33Zurn:sha1:80095da1aa47978cdba26c2b3d254a99c075cf53
Previously, arti's primary keystore was referred to as its "default"
keystore. However, "default" is inaccurate here: there is no way to
meaningfully override this "default" (the "default" store acts as the
main keystore). Throughout the codebase, we query all keystores for keys
(including the secondary ones), but only ever write to the
default/primary keystore. This is OK for now, because it enables us to
have one mutable keystore, and multiple secondary, read-only stores.
tor-keymgr: added dummy implementation of ArtiEphemeralKeyStore2024-09-20T23:13:14ZMorganmorgan@torproject.org2024-09-07T21:01:26Zurn:sha1:bc1b57da446acddf721039589692e437e59eb261