mirrors/arti.git/crates/tor-keymgr/src/arti_path.rs, branch arti-v1.1.12mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.122023-12-07T12:12:34Ztor-keymgr: ArtiPath[Component]: Manually reformat derive lists2023-12-07T12:12:34ZIan Jacksonijackson@chiark.greenend.org.uk2023-12-07T11:43:49Zurn:sha1:924fa9b9e0962ed8ed9a3e3ffc007a03d0a54aeftor-keymgr: ArtiPath: impl serde2023-12-07T12:12:34ZIan Jacksonijackson@chiark.greenend.org.uk2023-12-07T11:42:28Zurn:sha1:5e0131455966fadf0c0421fdd8d768193b056c72tor-keymgr: ArtiPathComponent: Use unqualified names2023-12-07T12:12:34ZIan Jacksonijackson@chiark.greenend.org.uk2023-12-07T11:40:50Zurn:sha1:1d13d7958e355fddb8e6441bf03df2a8310fcde2
This makes this like the list for ArtiPath.
tor-keymgr: ArtiPath[Component]: Don't DerefMut2023-12-07T12:12:34ZIan Jacksonijackson@chiark.greenend.org.uk2023-12-07T11:46:08Zurn:sha1:54ec3725bc59aafea37798a442823a9c2128a086
That would allow construction of invalid paths.
tor-keymgr: ArtiPath[Component]: Properly validate in FromStr2023-12-07T12:12:34ZIan Jacksonijackson@chiark.greenend.org.uk2023-12-07T11:45:30Zurn:sha1:2add6a03f8608ee48a95b33784cf98ed936c7183
As pointed out in
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1796#note_2974513
derive-more just parses like the inner type, so an unvalidated String.
That is wrong.
tor-keymgr: ArtiPath[Component]: Use d-a to generate various methods2023-12-07T12:12:34ZIan Jacksonijackson@chiark.greenend.org.uk2023-12-07T11:26:56Zurn:sha1:0b9ae16f6d79c4e02c7a8d177433832f433dffc3
Now ArtiPath too is TryFrom<String> and AsRef<str>.
tor-keymgr: ArtiPath: Introduce validate_str2023-12-07T12:12:34ZIan Jacksonijackson@chiark.greenend.org.uk2023-12-07T11:20:30Zurn:sha1:296145fdbbf61da63588d528297a47bcba381a2e
This makes it more like ArtiPathComponent and will allow more unification
tor-keymgr: ArtiPath::new: Rename a confusing variable2023-12-07T12:12:34ZIan Jacksonijackson@chiark.greenend.org.uk2023-12-07T11:13:45Zurn:sha1:5c278db30b0b6c02a9bdbe7f64256396e7b11d66
Rebinding inner locally like this confused me.
tor-keymgr: ArtiPathSyntaxError: rename from ArtiPathError2023-12-07T12:12:34ZIan Jacksonijackson@chiark.greenend.org.uk2023-12-06T16:01:17Zurn:sha1:aafba53d7672b3535302863ff09cf8058043f83f
The previous name was ambiguous, and confusable with KeyPathError
(of which it is, basically, a variant).
tor-keymgr: Abolish unneeded StdResult alias in arti_path2023-12-07T12:12:31ZIan Jacksonijackson@chiark.greenend.org.uk2023-12-06T15:25:39Zurn:sha1:65554e9fe735a210d8d2d7425c51ef7736d35c8f