mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.3.2 2024-12-04T16:42:39Z 2024-12-04T16:42:39Z Gabriela Moldovan gabi@torproject.org 2024-11-25T17:41:33Z urn:sha1:b9bab9c7c71a6440a5238948fefdd0a253059eca 2024-12-02T18:27:29Z Gabriela Moldovan gabi@torproject.org 2024-12-02T18:27:29Z urn:sha1:a28e4fb86ff86daa779f50f549d4933f59af14ea 2024-11-14T11:15:43Z Gabriela Moldovan gabi@torproject.org 2024-11-14T11:13:54Z urn:sha1:c9f55e8df5364acef6b7bf21a3426d81d0b745e0 These are not actually needed anywhere. In fact, it's a bad idea to have them in the first place (see the comment from the dummy `KeyMgr` impl block). 2024-10-31T14:25:54Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-10-31T14:25:54Z urn:sha1:ef1d4377c86f73f124c8f43a7bea994888f6900b 2024-10-08T13:23:17Z Gabriela Moldovan gabi@torproject.org 2024-09-25T18:23:26Z urn:sha1:05066b0ebfc769cb54018d9633646ace70456ee3 This is only used for representing portions of `ArtiPath`s, so let's rename it accordingly. 2024-10-08T13:23:17Z Gabriela Moldovan gabi@torproject.org 2024-09-25T18:20:08Z urn:sha1:b2170d7d8a680255e389a3600444b50bd9d3a363 `KeyPath::matches` now returns a boolean (because we can't return a matching "range" for `CTorPaths`, because unlike ArtiPaths, they're not represented as `String`s, and do not have variable parts that need to be captured). 2024-10-08T13:23:17Z Gabriela Moldovan gabi@torproject.org 2024-09-20T15:39:43Z urn:sha1:971304d31bdb38fd9e6133941d2e021d4bb7dd6d C Tor's client restricted discovery keys don't have the service hsid encoded in the filename (the hsid of the service each key is associated with is encoded in contents of the key file). This means that given a key specifier like `HsClientDescEncKeypairSpecifier` (which is a wrapper over an HsId), we can't actually compute the relative path of the key in its `KeySpecifier::ctor_path()` implementation. To do so we would need to access the keystore to figure out which path contains the requested HsId, which we can't (and shouldn't!) do from within the `KeySpecifier` impl. This suggests the String newtype (representing a relative path) we previously had is not a good abstraction for `CTorPath`s. Moreover, `CTorPath` are static (they don't have dynamic components like `ArtiPath`), so it makes more sense to model `CTorPath` as an enum. The new `CTorPath::ClientHsDescEncKey(HsId)` variant will be used to instruct the C Tor client keystore to find the file that contains the specified `HsId`, while the `Service` variant will be used for hidden service keys. 2024-10-08T13:23:16Z Gabriela Moldovan gabi@torproject.org 2024-09-26T14:39:42Z urn:sha1:68376b22557e15404539f8dec40f9f11bf520f1f The config will soon contain secondary C Tor keystore configuration too, so the `arti` namespacing is about to stop making sense. I recommend reviewing this commit using `git diff --color-moved=zebra --ignore-space-change` 2024-09-30T16:20:11Z Nick Mathewson nickm@torproject.org 2024-09-30T16:20:11Z urn:sha1:68e9400e9c14863b8b20b3c6ab6a532bc83530a5 2024-09-23T17:58:55Z Gabriela Moldovan gabi@torproject.org 2024-09-23T14:23:13Z urn:sha1:b3cf77ed943e97428d2d6c3ef1f352ee9b273617 I am adding `is_enabled()` back because I plan to un-deprecate the `enabled` setting.