mirrors/arti.git/crates/tor-key-forge/src/traits.rs, branch arti-v1.8.0

tor-llcrypto: Rename rsa::PrivateKey to rsa::KeyPair.

2025-09-08T21:12:10Z

As discussed with gabi on IRC today.

tor-key-forge: Add RSA key types.

2025-09-08T21:07:35Z

Some things I'm still considering here: * We may want to define a tor_llcrypto::pk::rsa::Signature newtype. * We likely want to rename tor_llcrypto::pk::rsa::PrivateKey to RsaKeypair.

Switch Cargo.toml files to edition 2024.

2025-08-07T15:28:36Z

First, run ``` git grep -l "^edition =" | xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;' ``` Second, manually verify that all Cargo.toml files have changed, and nothing else has changed. Third, run cargo fmt again.

fix `clippy::doc_overindented_list_items`

2025-04-03T17:32:58Z

Example: ```text warning: doc list item overindented --> crates/arti-rpc-client-core/src/conn/connimpl.rs:322:9 | 322 | /// indicates that no more messages will be received for this request. | ^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items note: the lint level is defined here --> crates/arti-rpc-client-core/src/lib.rs:8:9 | 8 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::doc_overindented_list_items)]` implied by `#[warn(clippy::all)]` ```

Use an EntropicRng trait to enforce key generation rules.

2025-03-24T19:11:48Z

We want to require that whenever we generate a key that's persistent (stored in KeyMgr), it's going to be made from a stronger-than-usual Rng. This trait helps us enforce that. We also add a FakeEntropicRng struct to use for testing. Note that this turned up a case that we'd missed, which required an internal change in tor-hsservice.

key-forge: Use CryptoRng from rand.

2025-03-18T16:09:44Z

Previously we used the version signature::rand_core for some reason, but that's now incompatible.

tor-key-forge: Remove no longer needed ItemType impl for KeyUnknownCert.

2025-01-13T19:29:19Z

No longer used, because we're now using `ParsedEd25519Cert` instead of `KeyUnknownCert` to represent parsed but not yet validated certs.

tor-key-forge: Implement ItemType for ParsedEd25519Cert.

2025-01-13T19:28:23Z

This will enable us to retrieve it from the keystore as an `ErasedKey` (side note, we should rename `ErasedKey` to `ErasedItem`).

tor-key-forge: Fill out the InvalidCertError type.

2025-01-13T19:28:21Z

We'll soon use this.

tor-key-forge: Add ItemType impl for KeyUnknownCert.

2025-01-13T19:22:37Z

`KeyUnknownCert` will soon be used as the `ToEncodableCert::ParsedCert` type for Tor ed25519 certs. For example, the `ToEncodableCert` impl for `RelaySigningKeyCert` will look like this: ```rust pub struct RelaySigningKeyCert(EncodedEd25519Cert); impl ToEncodableCert for RelaySigningKeyCert { type ParsedCert = KeyUnknownCert; type EncodableCert = EncodedEd25519Cert; type SigningKey = RelayIdentityKeypair; fn validate( cert: Self::ParsedCert, subject: &RelaySigningKeypair, signed_with: &Self::SigningKey, ) -> Result { // TODO: validate `KeyUnknownCert` // and convert it to an EncodedEd25519Cert // (we don't yet an easy way to perform this conversion) } fn to_encodable_cert(self) -> Self::EncodableCert { self.0 } } ```