mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.1 2025-01-13T19:29:19Z 2025-01-13T19:29:19Z Gabriela Moldovan gabi@torproject.org 2024-12-12T16:43:18Z urn:sha1:d87d11c7a83b158bdb3ea52ff545462a5a5278c0 No longer used, because we're now using `ParsedEd25519Cert` instead of `KeyUnknownCert` to represent parsed but not yet validated certs. 2025-01-13T19:28:23Z Gabriela Moldovan gabi@torproject.org 2024-12-12T13:58:43Z urn:sha1:beacb0a729f1c598b2386a4ddbea88dc7f8aa9d8 This will enable us to retrieve it from the keystore as an `ErasedKey` (side note, we should rename `ErasedKey` to `ErasedItem`). 2025-01-13T19:28:21Z Gabriela Moldovan gabi@torproject.org 2024-12-12T17:00:36Z urn:sha1:88927e965a93ba9153a33068d2a04f2704b092aa We'll soon use this. 2025-01-13T19:22:37Z Gabriela Moldovan gabi@torproject.org 2024-12-11T14:09:16Z urn:sha1:7576e1345d1230f48414a38f0c1dcd558c479984 `KeyUnknownCert` will soon be used as the `ToEncodableCert::ParsedCert` type for Tor ed25519 certs. For example, the `ToEncodableCert` impl for `RelaySigningKeyCert` will look like this: ```rust pub struct RelaySigningKeyCert(EncodedEd25519Cert); impl ToEncodableCert<RelaySigningKeypair> for RelaySigningKeyCert { type ParsedCert = KeyUnknownCert; type EncodableCert = EncodedEd25519Cert; type SigningKey = RelayIdentityKeypair; fn validate( cert: Self::ParsedCert, subject: &RelaySigningKeypair, signed_with: &Self::SigningKey, ) -> Result<Self, InvalidCertError> { // TODO: validate `KeyUnknownCert` // and convert it to an EncodedEd25519Cert // (we don't yet an easy way to perform this conversion) } fn to_encodable_cert(self) -> Self::EncodableCert { self.0 } } ``` 2025-01-13T19:22:36Z Gabriela Moldovan gabi@torproject.org 2024-12-10T20:27:38Z urn:sha1:d45ab843b6506dfbfea456ed585c34f60100a280 This is necessary because `ParsedCert`s will not be `EncodableItem`s. This is because we cannot (and don't want to) write certificates that have not yet been validated to the keystore. They do need to be retrievable from the keystore though, so we also change `ErasedKey` to be `Box<dyn ItemType>` instead. 2025-01-13T19:21:45Z Gabriela Moldovan gabi@torproject.org 2024-12-11T13:52:14Z urn:sha1:ff0e2a9ae1178d6f7a7b3d23ff2b87b8aa3560a0 We need two different types to represent * certs that have been parsed, but not yet validated (`KeyUnknownCert`) * newly generated encodable certs (`EncodedEd25519Cert`) Currently, we don't use `KeyUnknownCert` anywhere, and instead use `EncodedEd25519Cert` to represent "parsed" but not-yet-validated certs. This approach is wrong and relies on a broken (no-op) `EncodedEd25519Cert::from_bytes` implementation. A future commit will address this problem by replacing `EncodedEd25519Cert::from_bytes` with `Ed25519Cert::decode` to actually parse the cert upon retrieving it from the keystore. 2025-01-13T19:21:45Z Gabriela Moldovan gabi@torproject.org 2024-12-10T12:07:04Z urn:sha1:841e1f477f2bec92b5be80afcef16df9e1e50a20 In practice, we won't be able to obtain an `ToEncodableCert` type from an `EncodableItem` cert without validating it first, so we need to collapse `validate` into `from_encodable_cert`. Part of #1768 2024-12-11T16:13:10Z Gabriela Moldovan gabi@torproject.org 2024-12-11T16:11:54Z urn:sha1:cf6998c7e8fa42d29847759d96af3c5fe02ab5f0 This enables us to get rid of the tor-key-forge -> tor-hscrypto dependency, partially addressing the TODO from `tor_key_forge::traits`. This commit is mostly code motion. Best reviewed with `--color-moved`. See also #1778 2024-12-04T16:42:06Z Gabriela Moldovan gabi@torproject.org 2024-11-25T12:20:58Z urn:sha1:9fec1799d9ac41ac7dffa085d71a82c96cb5b076 2024-12-04T16:42:06Z Gabriela Moldovan gabi@torproject.org 2024-11-25T10:32:47Z urn:sha1:ec173384504649bd78be2889120308342b7a9731