mirrors/arti.git/crates/tor-hsservice/src, branch arti-v2.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.02026-06-17T13:38:44Zproto: Add crate-level exports for two extra stream types (fmt)2026-06-17T13:38:44ZGabriela Moldovangabi@torproject.org2026-06-17T13:31:26Zurn:sha1:d305c6c0a201703ce14fbcfdce1864aeda9cc8dcmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
metrics: Add descriptions and units for existing metrics.2026-06-02T14:56:19ZWesley Aptekar-Casselsme@wesleyac.com2026-05-26T20:41:47Zurn:sha1:0afbc45bb2903ca06ba15851393e6fbd347e2b92config: Add a method to fill in a builder with unset defaults2026-05-27T12:05:52ZNick Mathewsonnickm@torproject.org2026-05-18T14:13:34Zurn:sha1:f1df3d1c8d83fd63d484cccf0bf45534f0369761
This new method modifies a builder by replacing any unset values
that have a default with that default. We're using this method
so that we can re-serialize a builder into a `ConfigurationTree`
with all of its default values included.
In all cases, `b.apply_defaults()?; b.build()` should produce
the same output as `b.build()`.
The interesting parts of this commit are in tor_config::load
and tor_config::derive. The rest of this commit just adds
`apply_defaults` to other builders that _aren't_ made with
`derive_deftly(TorConfig)`.
hsservice: Set the current random value for the custom netdir2026-05-21T15:55:18ZGabriela Moldovangabi@torproject.org2026-05-21T15:00:52Zurn:sha1:ac13f3a453135c8d6509f0e093aba42cfd6ac696
This test was supposed to set both the current and the previous SRV in the
test netdir, but was actually only setting the previous one.
With the new SRV fixes from ee07c441909b41d5fbbfbffae310e954a69db478,
all the hsservice tests using this netdir were panicking on an
`.unwrap()`, because the SRV for the "previous" TP could not be found,
which is actually what you'd expect to happen, given that the netdir was
built with only one SRV. The reason the tests weren't failing before is,
funnily enough, because of the bug in SRV calculation that is fixed in
ee07c441909b41d5fbbfbffae310e954a69db478:
In `tor-netdir`, the `extract_srvs()` function (correctly) only returned
a single SRV from the consensus (the "previous one", set with
`bld.shared_rand_prev()` in the test), but the `find_params_for_time()`
was wrongly matching up that same SRV with multiple time periods. This
happened because the old implementation was computing the "previous SRV"
validity interval as:
* ts_begin = `[start_of_day_containing(consensus_ts) - ONE_DAY`
* ts_end = `ts_begin + srv_interval`
And because the test SRV interval is 288h(!), and the test TP length is
only 24h, the validity period of the previous SRV (incorrectly) covered
two TPs (both the previous and the current). So as a result, the test
was "successfully" getting back the same SRV for both the previous and
the current TP.
The bug was introduced in the commit that originally added the hsservice
tests: 279842526591918e25ca97e6392f211a50192396
Upgrade rand crates to 0.10.2026-05-12T20:55:43ZWesley Aptekar-Casselsme@wesleyac.com2026-05-07T20:06:21Zurn:sha1:a18167928901d8c88cd1cdd87346de8ad1ee42a2
When the circ-padding feature is enabled, we use maybenot, which does
not yet support rand 0.10. In the meantime, enabling this feature pulls
in rand 0.9. This is not ideal, but should be okay as a temporary
situation.
This also replaces the use of ReseedingRng (which was removed in 0.10)
with the reseeding_rng crate. This is somewhat less performant, but it
should be okay.
dirclient, hsservice: Use Arc<str> for hsdesc publishing.2026-05-12T12:10:03ZNick Mathewsonnickm@torproject.org2026-04-25T21:30:17Zurn:sha1:176fcd170d2a9adc38ff82e42a5167a940e47268
This saves a little memory, but the technique will help save more
memory for other uploads.
tor-dirclient: Avoid copying bytes that we want to POST.2026-05-12T12:10:03ZNick Mathewsonnickm@torproject.org2026-04-25T21:13:45Zurn:sha1:1f6d57019a4b2a1e5955e6b89e066d58718902d5
This required a change to the hsservice tests, which previously
assumed that we'd perform one write per request.
hsservice, llcrypto, SecurityResponse: use cfg({true,false})2026-05-07T12:08:01ZNick Mathewsonnickm@torproject.org2026-05-04T13:45:55Zurn:sha1:0c4ed480afc9a96b37db9630c7ee3185a69fa999hsclient, hsservice: Use unquoted paths in ctor_path attr2026-04-16T09:22:54ZGabriela Moldovangabi@torproject.org2026-04-15T13:13:44Zurn:sha1:ddddac1f5be762cdb954114f130aad8e6915ecba