mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.4 2024-04-03T12:15:08Z 2024-04-03T12:15:08Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-04-02T14:59:44Z urn:sha1:9fd94822a4dd2c267b0ebdca122bde8123d506d1 Found by "git grep adhoc" and manual inspection. 2024-04-03T12:11:39Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-04-02T11:58:49Z urn:sha1:b71d0bf6cd413650550b40ce81e02dc47ae2fa5e This is the combination of a number of separate commits, many of which were generated by seddery, and then rebased and squashed. Cargo.toml perl -i~ -pe 's{^derive-adhoc}{derive-deftly = "0.10"}' crates/*/Cargo.toml (not regenerated during rebase) update Cargo.lock `cargo fetch` without --locked (regenerated during rebase) seddery git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{^use derive_adhoc}{use derive_deftly}' git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bdefine_derive_adhoc\b}{define_derive_deftly}g' git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bAdhoc\b}{Deftly}g if m{derive}' git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\#\[derive_adhoc\b}{#[derive_deftly}g' git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{use derive_adhoc}{use derive_deftly}' git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bderive_adhoc\b}{derive_deftly_adhoc} if m{use.*deftly}' git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bderive_adhoc!}{derive_deftly_adhoc!}' (not regenerated during rebase) Manually add `#[derive_deftly_adhoc]` where needed. seddery git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\#\[adhoc\b}{#[deftly}g' git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bderive_adhoc_template}{derive_deftly_template}' (not regenerated during rebase) Manually fix up an import Manually update some builder attrs Manually fix up tor_rtmock::time_core This was missed in my seddery, due to me rebasing the branch and not redoing the seddery. 2024-03-13T16:30:53Z Nick Mathewson nickm@torproject.org 2024-03-13T16:30:53Z urn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320c 2023-11-01T13:19:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-11-01T12:19:15Z urn:sha1:0fbee871a058cc52376a4143fba693eb49f5ca4c Retain the TODO for making this properly pub somewhere. 2023-10-31T18:56:25Z Gabriela Moldovan gabi@torproject.org 2023-10-31T18:56:25Z urn:sha1:54867105187997e418c7bcf75470a4b0e184b559 `cargo clippy --all-features --tests` is reporting warnings about the unnecessary cloning. 2023-10-30T18:06:22Z gabi-250 gabi@torproject.org 2023-10-30T18:06:22Z urn:sha1:0a3f52a518da97bf5be5a64411648dd178c7d21a 2023-10-30T13:16:37Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-10-30T12:36:03Z urn:sha1:54c1b038712d6951c5d748dbec21bdb41c387725 2023-10-30T13:16:37Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-10-30T12:57:12Z urn:sha1:a14cf6e843b3da0db5ded6787b8a5fad0411d76c We have a profusion of similar methods with similar names and similar documentation. Centralising the documentation in a trait is helpful. This also means that callers can just naturally call `.update` rather than needing to spell out `.update_abs` vs `.update_rel` etc. 2023-10-30T13:16:37Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-10-30T12:38:38Z urn:sha1:9d41328ea603124d3a32664d3176045faf6e6e5a Clarify this in the update functions, and in the general discussion. We don't want zero timeouts. 2023-10-16T13:06:06Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-10-16T11:34:33Z urn:sha1:603ff45184ed04a88b9b748ae504e62d1cc9b702 Simply running `rustfmt` makes a mess. This new formatting is less nice but repo policy requires that the layout is a fixed point under rustfmt and this is the least bad fixed point I found.