mirrors/arti.git/crates/tor-hsservice/src/timeout_track.rs, branch arti-v1.2.1mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.12024-03-13T16:30:53ZRun maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320ctor-hsservice: timeout_track: Remove some unnecessary allows2023-11-01T13:19:45ZIan Jacksonijackson@chiark.greenend.org.uk2023-11-01T12:19:15Zurn:sha1:0fbee871a058cc52376a4143fba693eb49f5ca4c
Retain the TODO for making this properly pub somewhere.
tor-hsservice: Remove unnecessary clone()s.2023-10-31T18:56:25ZGabriela Moldovangabi@torproject.org2023-10-31T18:56:25Zurn:sha1:54867105187997e418c7bcf75470a4b0e184b559
`cargo clippy --all-features --tests` is reporting warnings about
the unnecessary cloning.
Fix typo in doc comment2023-10-30T18:06:22Zgabi-250gabi@torproject.org2023-10-30T18:06:22Zurn:sha1:0a3f52a518da97bf5be5a64411648dd178c7d21ator-hsservice: timeout_track: Test `update` functions2023-10-30T13:16:37ZIan Jacksonijackson@chiark.greenend.org.uk2023-10-30T12:36:03Zurn:sha1:54c1b038712d6951c5d748dbec21bdb41c387725tor-hsservice: timeout_track: Provide `update` via a trait2023-10-30T13:16:37ZIan Jacksonijackson@chiark.greenend.org.uk2023-10-30T12:57:12Zurn:sha1:a14cf6e843b3da0db5ded6787b8a5fad0411d76c
We have a profusion of similar methods with similar names and similar
documentation. Centralising the documentation in a trait is helpful.
This also means that callers can just naturally call `.update` rather
than needing to spell out `.update_abs` vs `.update_rel` etc.
tor-hsservice: timeout_track: Clarify edge cases2023-10-30T13:16:37ZIan Jacksonijackson@chiark.greenend.org.uk2023-10-30T12:38:38Zurn:sha1:9d41328ea603124d3a32664d3176045faf6e6e5a
Clarify this in the update functions, and in the general discussion.
We don't want zero timeouts.
tor-hsservice: timeout track: Worsify formatting2023-10-16T13:06:06ZIan Jacksonijackson@chiark.greenend.org.uk2023-10-16T11:34:33Zurn:sha1:603ff45184ed04a88b9b748ae504e62d1cc9b702
Simply running `rustfmt` makes a mess.
This new formatting is less nice but repo policy requires that the
layout is a fixed point under rustfmt and this is the least bad fixed
point I found.
tor-hsservice: timeout track: Add some discussion2023-10-16T13:00:14ZIan Jacksonijackson@chiark.greenend.org.uk2023-10-16T10:47:39Zurn:sha1:24c50b34935951ebf7261eb5a1e200acd4d2fa04tor-hsservice: timeout track: Add an example doctest2023-10-16T13:00:14ZIan Jacksonijackson@chiark.greenend.org.uk2023-10-12T17:50:44Zurn:sha1:70c1a65d7415c6223790504bab8e4698eebb12fa