mirrors/arti.git/crates/tor-hsservice/src/svc/publish, branch arti-v1.1.11

Remove RngCompatExt.

2023-11-29T15:55:04Z

This code was needed with the old version of dalek-cryptography, which wasn't compatible with up-to-date versions of the `rand` crate(s). But now that we've upgraded, we can drop this. (We could have left it around and deprecated it, but we are already making a breaking change to tor-llcrypto by upgrading dalek-cryptography.)

Convert to the latest versions of dalek-cryptography

2023-11-29T15:34:58Z

The main changes that we have to adjust for are as follows: * In x25519-dalek: * `StaticSecret` is now behind a feature. * `StaticSecret::new` is deprecated in favor of `StaticSecret::random_from_rng`. * StaticSecret no longer does its own clamping. * In ed25519-dalek: * `SecretKey` has (in effect) been renamed to `SigningKey`. The name `SecretKey` is now an alias for `[u8; 32]`. * `SigningKey` is effectively a keypair, since it contains a public key as well. * `PublicKey` has been renamed to `VerifyingKey`. * The functions to extract a signing key and verifying key have been renamed as you might expect. * `ExpandedSecretKey` has been moved to `hasmat` and no longer implements `sign`. * `ExpanededSecretKey` now has as its elements a scalar and a hash prefix. * Various functions that took `&[u8]` now take `&[u8; N]`. * We no longer need a wrapper for older versions of rand. There is a single test in tor-keymgr that does not pass. I've marked it as ignore for now, in hopes that @gabi-250 can help me figure it out. This closes #808. There are several changes I want to make before we merge, however. They are marked with TODO DALEK.

Merge branch 'persist-prefix' into 'main'

2023-11-28T10:23:43Z

HSS IPT persistence - preparatory work See merge request tpo/core/arti!1755

Merge branch 'keymgr-errors' into 'main'

2023-11-27T20:04:48Z

tor-keymgr: Add a top-level Error enum Closes #1113 See merge request tpo/core/arti!1751

tor-hsservice: ipt_set: Make note_publication_attempt a method on PublishIptSet

2023-11-27T19:24:55Z

We're going to move the last_descriptor_expiry_including_slop data out of IptSet.

tor-hsservice: ipt_set: Make PublishIptSet a struct

2023-11-27T19:24:55Z

We're going to add another field here. No functional change, just much churn.

tor-keymgr: Add a top-level error type.

2023-11-21T12:05:11Z

Previously, the `tor_keymgr::Error` type was `Box`. This forced us to impl `KeystoreError` for any error returned by the keymgr (including those that were not coming from a `Keystore` impl). Now, `tor_keymgr::Error` is an non-exhaustive enum and the `Box` opaque error type is only returned from `Keystore` impls The reason we're keeping the `dyn KeystoreError` error type is because it enables `Keystore` implementors to use their own error types. Without it, they would have to choose from our (closed) set of error variants, which may not be suitable for their keystore. See #901.

HSS publisher error: lack of netdir: clarify message

2023-11-20T18:22:30Z

HSS publisher: do not crash reactor if netdir unavailable

2023-11-20T17:26:58Z

It might come back. This introduces a new bug relating to logging, but it does abolish one of the variants of ReactorError.

HSS publisher errors: Declare that we want to abolish ReactorError

2023-11-20T17:19:21Z

And explain why this isn't just a question of merging it with FatalError.