mirrors/arti.git/crates/tor-hsservice/src/svc.rs, branch arti-v1.1.11mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.112023-11-29T20:51:12ZMerge branch 'semver-breaking-upgrade-of-the-daleks' into 'main'2023-11-29T20:51:12ZNick Mathewsonnickm@torproject.org2023-11-29T20:51:12Zurn:sha1:bdea25be86cd3e0e327d34f6748140af1c6f3b69
Convert to the latest versions of dalek-cryptography
Closes #808
See merge request tpo/core/arti!1767llcrypto: Hide the members of ExpandedKeypair.2023-11-29T17:10:18ZNick Mathewsonnickm@torproject.org2023-11-29T17:10:18Zurn:sha1:adc3209c6bef9cc03542c31c22c0f308938e1643
With this change, we no longer expose the ExpandedSecretKey
unescorted, which makes it harder to misuse the API.
tor-hsservice: test_temp_dir: Rename to used_by2023-11-29T16:41:37ZIan Jacksonijackson@chiark.greenend.org.uk2023-11-29T16:41:21Zurn:sha1:ea210fa5747729a8d489659df673c11ad451a55a
from obtain_in.
As per irc discussion.
tor-hsservice: test_temp_dir: Rename to TestTempDirGuard2023-11-29T16:41:30ZIan Jacksonijackson@chiark.greenend.org.uk2023-11-29T16:40:25Zurn:sha1:340e2298fa62f08286efb6b2f38baeb5ce22ee2f
from UsingTempDir.
As per irc discussion.
tor-hsservice tests: create_keymgr: add a doc comment2023-11-29T16:12:58ZIan Jacksonijackson@chiark.greenend.org.uk2023-11-29T15:37:27Zurn:sha1:119559e4843bd0db403b36b80050c6858f1cc452Remove RngCompatExt.2023-11-29T15:55:04ZNick Mathewsonnickm@torproject.org2023-11-29T15:49:26Zurn:sha1:7fb24cb69da537ac04ab2dae80997c6d481622ef
This code was needed with the old version of dalek-cryptography,
which wasn't compatible with up-to-date versions of the `rand`
crate(s). But now that we've upgraded, we can drop this.
(We could have left it around and deprecated it, but we are already
making a breaking change to tor-llcrypto by upgrading
dalek-cryptography.)
Convert to the latest versions of dalek-cryptography2023-11-29T15:34:58ZNick Mathewsonnickm@torproject.org2023-11-21T15:58:29Zurn:sha1:98037a2c788bd901679139178d25f855324637f3
The main changes that we have to adjust for are as follows:
* In x25519-dalek:
* `StaticSecret` is now behind a feature.
* `StaticSecret::new` is deprecated in favor of
`StaticSecret::random_from_rng`.
* StaticSecret no longer does its own clamping.
* In ed25519-dalek:
* `SecretKey` has (in effect) been renamed to `SigningKey`. The name
`SecretKey` is now an alias for `[u8; 32]`.
* `SigningKey` is effectively a keypair, since it contains a
public key as well.
* `PublicKey` has been renamed to `VerifyingKey`.
* The functions to extract a signing key and verifying key have
been renamed as you might expect.
* `ExpandedSecretKey` has been moved to `hasmat` and no longer
implements `sign`.
* `ExpanededSecretKey` now has as its elements a scalar and a hash
prefix.
* Various functions that took `&[u8]` now take `&[u8; N]`.
* We no longer need a wrapper for older versions of rand.
There is a single test in tor-keymgr that does not pass. I've
marked it as ignore for now, in hopes that @gabi-250 can help me
figure it out.
This closes #808. There are several changes I want to make before
we merge, however. They are marked with TODO DALEK.
tor-hsservice tests: Make create_keymgr pub(crate)2023-11-28T18:22:22ZIan Jacksonijackson@chiark.greenend.org.uk2023-11-27T16:46:11Zurn:sha1:d52919e57bd732bd789568f5c581e14d0e731afe
We're going to want this for other tests in this crate.
tor-hsservice tests: Change create_keymgr to use TestTempDir2023-11-28T18:22:22ZIan Jacksonijackson@chiark.greenend.org.uk2023-11-27T16:45:17Zurn:sha1:7d68bcce62c2c909d67121e0493d5233c9594b29Merge branch 'keymgr-derive-builder' into 'main'2023-11-28T12:12:09Zgabi-250gabi@torproject.org2023-11-28T12:12:09Zurn:sha1:009533057f57b3c8e5e81a70314f2ead97db63e4
tor-keymgr: Derive Builder for KeyMgr.
Closes #1114
See merge request tpo/core/arti!1760