mirrors/arti.git/crates/tor-hsservice/src/req.rs, branch ios-sqlite-hacksmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks2023-09-18T11:35:46Ztor-hsservice: Apply deferred rustfmt churn2023-09-18T11:35:46ZIan Jacksonijackson@chiark.greenend.org.uk2023-09-18T11:35:46Zurn:sha1:0e86f5781933734b9316a526877a416d8c882252tor-hsservice: Unify ids as IptLocalId replacing IntroPointId2023-09-18T10:53:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-09-18T10:42:26Zurn:sha1:6a1bd5b2be447e96c33f4b3cb4d877ec085ab205
IntroPointId was RelayIds but that's wrong, because there can be
different IPTs at the same relay - but also because an established IPT
might change its RelayIds.
Use IptLocalId instead, which I think is the type we decided to use
for this, and which is, conveniently, Copy.
And change the variable names to match, everywhere.
Specifically: in places where an intro point is implied (ipt_mgr.rs,
ipt_establish.rs) use the name `lid` everywhere, like in ipt_mgr.rs.
Elsewhere, use `ipt_lid`.
(We could use a longer name, but in that case it should be changed in
ipt_mgr.rs too.)
No actual functional change in this commit.
HSS: Refactor RendRequest so we can return a stream of it.2023-08-22T14:50:43ZNick Mathewsonnickm@torproject.org2023-08-18T17:06:42Zurn:sha1:ec6721ec9412fa08a47855965c6a1e0ceb6e63fe
We need a type that holds a rend_handshake::IntroRequest object
internally, but where we don't materialize that object from the
Introduce2 message inside the MsgHandler, since that's more crypto
than we want to put in that task.
tor-hsservice errors: Distinguish operational errors by context2023-08-17T12:28:44ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-17T12:04:53Zurn:sha1:360c90a9d8ec14c713560bc089f9706527056d31
At the very least, I need FatalError to be distinct:
IptEstablisher::new ought not to fail unless everything is terrible.
Add a the Spawn variant to FatalError (that we'll need soon) and the
Bug variant (which it seems likely we might need).
This also gets rid of the crate-level Result alias.
tor-hsservice errors: Use Bug for methods that oughtn't to fail2023-08-17T12:19:21ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-17T12:02:34Zurn:sha1:5e047da9cc4017433b7282858a33543587a976ee
If the service encouters operational errors, surfacing them here is
not helpful. So these methods ought to work, if they weren't called
erroneously.
tor-hsservice errors: Use `crate::Result` rather than imports2023-08-17T12:12:23ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-17T12:00:23Zurn:sha1:c391ac2a908ff4b9ea299bf086300a55ef338214
We want to change the error return types of many methods, so we need a
way to name `std::result::Result`.
We could use `StdResult`, but, actually, properly distinguishing the
kinds of errors that can occur in various contexts means we don't
actually want a single Error type for the whole crate, so
`crate::Result` is going to go away.
hsservice: Adapt API sketches from onion-service-notes.md2023-07-31T17:47:44ZNick Mathewsonnickm@torproject.org2023-07-31T13:52:53Zurn:sha1:20afc76c0aa96fe9ad1661afc826b54a562e37behsservice: Adapt data structures from onion-service-notes.md2023-07-31T17:47:44ZNick Mathewsonnickm@torproject.org2023-07-31T13:52:53Zurn:sha1:20b3679dbbbf54db7f6e6c0e92949dbcef5a68f3
Also, removed some older structures that don't make sense in the
current design.
Closes #970