mirrors/arti.git/crates/tor-hsservice/src/req.rs, branch arti-v1.1.10 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.10 2023-10-24T16:51:23Z hsserive::req: Yes, leave these functions as async and fallible. 2023-10-24T16:51:23Z Nick Mathewson nickm@torproject.org 2023-10-24T16:51:23Z urn:sha1:87c95dde0025a9d0aa7d7e81aa9d27ac1505403c Enough of them have turned out to need to be async so far that I don't think it's a great idea to commit to making any of them not-async forever. Additionally, we've written the code that uses these, and having them be async didn't seem to cause any major trouble. By the same "we may want to make these more complicated underneath" argument, we should IMO leave them as fallible. hsserive::req: Lower/remove allowed warnings 2023-10-24T16:49:35Z Nick Mathewson nickm@torproject.org 2023-10-24T16:49:35Z urn:sha1:d92433ccda9bd1c7f8baab4e146c6d518906926f hss: Remove an unused type. 2023-10-24T16:47:19Z Nick Mathewson nickm@torproject.org 2023-10-24T16:47:19Z urn:sha1:b77429a74ef503798c9ec96a5947718a20e7b71c proto: Make StreamTarget::close() misuse less likely. 2023-10-17T12:41:44Z Nick Mathewson nickm@torproject.org 2023-10-17T12:39:39Z urn:sha1:308a27f0ac25c4608fd08d7c68fd1c5b305a8428 It turns out that we can make `IncomingStream::reject()` consume self, thus making it impossible to hit the double-close error from outside the `tor-proto` crate. Also, we rename `StreamTarget::close()` to `close_pending()` to better reflect its limited applicability. tor-hsservice: Narrow some dead code allows 2023-10-16T12:38:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-10-12T10:47:27Z urn:sha1:429c1bd551082c1e5bf045e7e926c2cf11d04e5a hss: use Arc to avoid copying on k_hss_ntor. 2023-10-12T13:25:39Z Nick Mathewson nickm@torproject.org 2023-10-12T13:25:39Z urn:sha1:bbe2cb8c366aa4d090f68aaf68afcd57cae22cb8 (We try to avoid making tons and tons of copies of a secret key.) Remove the (fairly bogus) HsNtorServiceInput type. 2023-10-12T13:20:44Z Nick Mathewson nickm@torproject.org 2023-10-12T13:17:38Z urn:sha1:4c88561eb979a43253422a2584b38b98b4827637 This will let avoid some copying inside our HSS code. hss: Remove OnionServiceDataStram type. 2023-09-27T17:42:50Z Nick Mathewson nickm@torproject.org 2023-09-27T13:21:40Z urn:sha1:d208c062fc2d78dc45d2b92d6eee441d5585b3db I think that the reason we added this was in case we needed different behavior from DataStream; but on reflection it does seem that we don't. Having a single type here will make things a bit simpler. hss: Implement methodss for StreamRequest 2023-09-27T17:42:50Z Nick Mathewson nickm@torproject.org 2023-09-26T20:18:02Z urn:sha1:6049bfe35a810ff4bdeec11c20d117eb49363fbb tor-proto: Make allow_stream_requests() not return a Result 2023-09-27T17:32:07Z Nick Mathewson nickm@torproject.org 2023-09-26T18:42:00Z urn:sha1:8cdd30491201c3a8d54e482ef4904a51900ea399 The function never yields anything but an `Ok`, so we can simplify its type. (Not a stable feature, so no semver entry needed)