mirrors/arti.git/crates/tor-hsservice/src/publish/reactor.rs, branch arti-v1.2.6 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.6 2024-07-09T17:27:28Z tor-hsservice: Remove unnecessary let-binding. 2024-07-09T17:27:28Z Gabriela Moldovan gabi@torproject.org 2024-07-09T17:27:05Z urn:sha1:6d9c3318bd63460e7885341b12d3d026d2ed8014 tor-hsservice: Specify the type when discarding value. 2024-07-09T17:21:17Z Gabriela Moldovan gabi@torproject.org 2024-07-09T17:13:44Z urn:sha1:ee199189149e6ff9a4ba6fc9c551c9dae647314b This should give us some confidence that we are not accidentally discarding results we should actually be using. Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2251#note_3046219 tor-hsservice: Ignore uninteresting netdir events in the publisher. 2024-07-09T13:25:23Z Gabriela Moldovan gabi@torproject.org 2024-07-09T12:10:40Z urn:sha1:8169adcc76b3e4cc80a16ff6095343a5f536db20 This also makes the publisher exit if the netdir event stream ends. tor-hsservice: Resolve warning about unused response variable. 2024-07-09T13:22:44Z Gabriela Moldovan gabi@torproject.org 2024-07-09T12:02:56Z urn:sha1:3caeaacfd219f4a07e00ffb0f0cfd1217105f163 It is OK to discard the response string (the response is validated below where we call `DirResponse::into_output_string()`). (Perhaps we should just make `DirResponse::check_ok()` public. That way, we could validate the response without having to handle its output string). tor-hsservice: Resolve a handful of unused variable warnings. 2024-07-09T13:22:44Z Gabriela Moldovan gabi@torproject.org 2024-07-09T12:00:15Z urn:sha1:7fff09020e164d675f27e71b1c019b8da96ad9ee tor-hsservice: Remove unused field from TimePeriodContext. 2024-07-09T13:22:44Z Gabriela Moldovan gabi@torproject.org 2024-07-09T11:56:52Z urn:sha1:1b533f6e8406333727d2a79a6642a40716e4b2d2 tor-hsservice: Remove unused variables. 2024-07-09T13:22:44Z Gabriela Moldovan gabi@torproject.org 2024-07-09T11:56:01Z urn:sha1:e7784e7e71f35f8f2625987795c6044430e8a9a1 tor-hsservice: Remove unnecessary locking. 2024-07-09T13:22:44Z Gabriela Moldovan gabi@torproject.org 2024-07-09T11:53:51Z urn:sha1:0de72a3af5f8e7ef4c1cbf072372357ddc858219 tor-hsservice: Remove unused code. 2024-07-09T13:22:44Z Gabriela Moldovan gabi@torproject.org 2024-07-09T11:49:58Z urn:sha1:34d2378b386243cf2eb3486c3880aaa27c024c49 This is being reimplemented as #1292 tor-hsservice: Remove unused publisher functions. 2024-07-09T13:20:49Z Gabriela Moldovan gabi@torproject.org 2024-07-09T11:41:59Z urn:sha1:a28e9ec850859cb48c03f2a51064c42f03a63b3f This removes a couple of unimplemented functions. These were supposed to be the starting point for #1217, but we won't be implementing that any time soon.