mirrors/arti.git/crates/tor-hsservice/src/publish/backoff.rs, branch arti-v1.7.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.7.02025-05-29T14:21:17Z*: suppress cognitive_complexity warnings from nightly2025-05-29T14:21:17ZNick Mathewsonnickm@torproject.org2025-05-21T14:48:35Zurn:sha1:5327d3e22a83b8469a5d4191d92e1364344ddc93
Apparently clippy nightly is better (or worse?) about detecting
complex functions than before, so I'm suppressing these warnings
where they occur.
I have mixed feelings about these warnings: On the plus side,
they really do help to detect functions that are twistier than they
need to be. On the minus side, they get confused by tracing macros,
and the "allows" do pile up. But on the plus side, those "allows"
do provide a way to find functions that need to be refactored,
and they are never uglier than the functions they decorate.
Resolve clippy warnings from 1.832025-05-13T18:53:41ZNick Mathewsonnickm@torproject.org2025-05-13T18:53:41Zurn:sha1:b182a9d05902bc5320ab486d055521f18b6b7832
Now that our MSRV is 1.83, clippy is happy to make more
recommendations for us.
tor-rt*: Apply deferred formatting churn2025-03-04T17:30:43ZIan Jacksonijackson@chiark.greenend.org.uk2025-02-26T18:13:00Zurn:sha1:39409be0db4def9ca5ffbd3bd14766112bcab527
rustfmt.
tor-rtcompat: Rename BlockOn to ToplevelBlockOn2025-03-04T17:30:43ZIan Jacksonijackson@chiark.greenend.org.uk2025-02-13T17:39:39Zurn:sha1:849558047071897b9bbdbdd28d06d15b52b3af10
We're going to distinguish top-level runtime entry, from *re*-entry to
an existing executor. It is most convenient to rename this trait
first. Documentation of the distinction will come later.
(We're going to retain the function name `block_on`, but we want the trait
to be more obviously a top-level only thing, though, so we give it a
name that will hopefully avoid it peroulating throughout the codebase..)
extract tor_async_utils::oneshot into ::oneshot-fused-workaround2024-08-28T14:27:46ZJim Newsomejnewsome@torproject.org2024-08-22T19:20:36Zurn:sha1:46f7f01092e6ac55e3e958dc3a2228b1d36e26a1
Having this in the `tor-async-utils` crate prevents us from doing both
of the following without introducing a circular dependency:
* using it in `tor-rtmock` (which we currently do, particularly in
tests).
* using `tor-rtmock` to test things in `tor-async-utils`. We don't do
this yet, but it is generally sensible to do so. In particular we
want to move the `stream_peak` module there, which is currently tested
with `tor-rtmock`.
Moving this into its own crate avoids this circular dependency.
tor-hsservice: Specify the type when discarding value.2024-07-09T17:21:17ZGabriela Moldovangabi@torproject.org2024-07-09T17:13:44Zurn:sha1:ee199189149e6ff9a4ba6fc9c551c9dae647314b
This should give us some confidence that we are not accidentally
discarding results we should actually be using.
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2251#note_3046219
tor-hsservice: Resolve a handful of unused variable warnings.2024-07-09T13:22:44ZGabriela Moldovangabi@torproject.org2024-07-09T12:00:15Zurn:sha1:7fff09020e164d675f27e71b1c019b8da96ad9eetor-hsservice: Move optional timeout to optionally_timeout().2024-04-02T17:41:39ZGabriela Moldovangabi@torproject.org2024-04-02T15:35:55Zurn:sha1:08b1b75bbb7e0051b0e429e97857b753a001fc69
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2064#note_3014793
tor-hsservice: s/timeout/overall_timeout for clarity.2024-04-02T14:58:38ZGabriela Moldovangabi@torproject.org2024-04-02T14:58:38Zurn:sha1:21ba4d453e650c672e985d41931cefcc9a04c10ator-hsservice: Add a test for the backoff runner's single_attempt_timeout().2024-04-02T11:56:05ZGabriela Moldovangabi@torproject.org2024-04-02T11:32:55Zurn:sha1:822afe162dce39f673068e887ea91d296601e417