mirrors/arti.git/crates/tor-hsservice/src/publish/backoff.rs, branch arti-v1.4.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.02024-08-28T14:27:46Zextract tor_async_utils::oneshot into ::oneshot-fused-workaround2024-08-28T14:27:46ZJim Newsomejnewsome@torproject.org2024-08-22T19:20:36Zurn:sha1:46f7f01092e6ac55e3e958dc3a2228b1d36e26a1
Having this in the `tor-async-utils` crate prevents us from doing both
of the following without introducing a circular dependency:
* using it in `tor-rtmock` (which we currently do, particularly in
tests).
* using `tor-rtmock` to test things in `tor-async-utils`. We don't do
this yet, but it is generally sensible to do so. In particular we
want to move the `stream_peak` module there, which is currently tested
with `tor-rtmock`.
Moving this into its own crate avoids this circular dependency.
tor-hsservice: Specify the type when discarding value.2024-07-09T17:21:17ZGabriela Moldovangabi@torproject.org2024-07-09T17:13:44Zurn:sha1:ee199189149e6ff9a4ba6fc9c551c9dae647314b
This should give us some confidence that we are not accidentally
discarding results we should actually be using.
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2251#note_3046219
tor-hsservice: Resolve a handful of unused variable warnings.2024-07-09T13:22:44ZGabriela Moldovangabi@torproject.org2024-07-09T12:00:15Zurn:sha1:7fff09020e164d675f27e71b1c019b8da96ad9eetor-hsservice: Move optional timeout to optionally_timeout().2024-04-02T17:41:39ZGabriela Moldovangabi@torproject.org2024-04-02T15:35:55Zurn:sha1:08b1b75bbb7e0051b0e429e97857b753a001fc69
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2064#note_3014793
tor-hsservice: s/timeout/overall_timeout for clarity.2024-04-02T14:58:38ZGabriela Moldovangabi@torproject.org2024-04-02T14:58:38Zurn:sha1:21ba4d453e650c672e985d41931cefcc9a04c10ator-hsservice: Add a test for the backoff runner's single_attempt_timeout().2024-04-02T11:56:05ZGabriela Moldovangabi@torproject.org2024-04-02T11:32:55Zurn:sha1:822afe162dce39f673068e887ea91d296601e417tor-hsservice: Use single_attempt_timeout in backoff Runner impl (fmt).2024-04-02T11:55:59ZGabriela Moldovangabi@torproject.org2024-04-02T11:55:59Zurn:sha1:7040f26ff17831023a5c2380ab9d4d4f8d9e2107tor-hsservice: Use single_attempt_timeout in backoff Runner impl.2024-04-02T11:52:31ZGabriela Moldovangabi@torproject.org2024-03-27T15:33:34Zurn:sha1:239ccf973f40b9f3144189a07906736d965e9d54
!2024 introduced `BackoffSchedule::single_attempt_timeout()`, partially
implementing #1259. This completes the implementation by moving the
per-iteration timeout from the publisher reactor to `backoff::Runner`.
Addresses https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2024?commit_id=a4f2bf5cb7d4027a49b74ec5a5298f7b9a3cf62e#note_3005097
Note: the `if should_retry` block is intentionally misindented, to make
reviewing the actual changes easier. A future commit will fix the
indentation. I originally wanted to suggest reviewing this commit using
`--ignore-space-change`, but I found that it makes things a bit
confusing (it shows some funky indentation around the parts that have
both whitespace changes and modifications).
Closes #1259
Run maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320cBackoffSchedule refactoring and improvements2024-03-07T21:06:28ZNeel Chauhanneel@neelc.org2024-03-07T21:06:28Zurn:sha1:2b44b6570e3f275249b925d9ce50d9ca932245e5