mirrors/arti.git/crates/tor-hsservice/src/ipt_set.rs, branch arti-v1.2.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.02024-02-01T11:21:44Ztor-hsservice: Use tor_persist::state_dir2024-02-01T11:21:44ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-30T15:42:13Zurn:sha1:b4a7f0fca0d231eb9c0298b78deee9ed3c1bbc7e
We no longer do replay log locking in IptManager::new. Instead, we
rely on the acquire_instance call in OnionService::launch, which ends
up with ipt_mgr getting an InstanceHandle (which contains a lock
guard).
OnionServiceStateMgr is abolished; it existed to deal with the
generics in the tor_persist::StateMgr API. state_dir has no
generics (other than the T being loaded/stored).
Many places (structs and argument lists) now have state_dir types
which embody a path (or a CheckeDir) along with a lock, rather than
separate path+lock+mistrust.
The creation/startup code uses the new calls from state_dir.
Other more minor changes:
- StartupError::StateDirectoryInaccessible contains tor_persist::Error
- test::create_storage_handles_from_state_dir changed and renamed,
from _from_state_mgr.
- replay::PersistFile's (separate) file lock is now fslock_guard's
tor-hsservice: tests: create_storage_handles: use a real directory2024-02-01T11:21:44ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-30T14:57:57Zurn:sha1:b119723c5ad09160ee920b289c3508a313f4a8bc
state_dir doesn't have the in-memory dummy implementation,
so there will have to be a real directory here.
Do that now, as prep.
tor-hsservice: storage: Move Arcs into type aliases2024-02-01T11:21:44ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-30T12:41:50Zurn:sha1:03825a0ccccf33940c4812d213e1ea00410c39d2
These are here because that's what you get from the tor_persist
singleton StageMgr API (for type erasure reasons). We're going to
change these to tor_persist::state_dir types and those don't involve
Arcs.
tor-hsservice: ipt_set: Make store method take &mut self2024-02-01T11:21:44ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-30T12:33:52Zurn:sha1:90ef0de5d3769e78ee460e60aca94f30f118fe87
Only people who can mutate the state ought to be saving it. Otherwise
there might be concurrent overwrites.
Base INTRO_POINT_EXPIRY_SLOP on OVERALL_UPLOAD_TIMEOUT.2024-01-25T16:37:30ZNick Mathewsonnickm@torproject.org2024-01-25T16:37:30Zurn:sha1:ec769a8aed5972f92283cdb4a98724b5ec6e569c
See discussion at #1210, "question 5".
Merge branch 'ratelim' into 'main'2024-01-11T17:08:45ZNick Mathewsonnickm@torproject.org2024-01-11T17:08:45Zurn:sha1:f6304630e8952b896496fd5e50339cafe556302a
tor-hsservice: todos: Use log_ratelim at one call site
See merge request tpo/core/arti!1871tor-hsservice: todos: Use log_ratelim at one call site2024-01-11T15:31:16ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-11T15:31:16Zurn:sha1:3bce1d5a03b65de6f3389f84e710000399cabd67tor-hsservice: todos: Remove a done TODO2024-01-11T15:23:42ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-11T15:23:24Zurn:sha1:3dd0a46dd797645db1cb64a7980c2533655ffb1f
The call to `load` is right there!
tor-hsservice: todos: Add another parameter to the ticket2024-01-11T15:22:48ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-11T15:22:33Zurn:sha1:b295b30345d23f62597dbb30a9c8e833efb93731
This is a MUST ticket.
Fix typos2024-01-08T18:19:11ZDimitris Apostoloudimitris.apostolou@icloud.com2024-01-04T18:32:22Zurn:sha1:4eb54be0657862f5d56b047c16c08dabde6a7377