mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.1.0 2025-08-13T18:27:16Z 2025-08-13T18:27:16Z Wesley Aptekar-Cassels me@wesleyac.com 2025-07-31T18:43:44Z urn:sha1:f0e0e51622d999f4632ed95b109a08229b372068 This disentangles the ReplyLog from the IptManager. This will allow us to make the InternalPowError type more public (in order to use it in the OnionServiceStatus code) without also having to make the CreateIptError type more public. 2024-02-01T11:21:44Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-30T15:42:13Z urn:sha1:b4a7f0fca0d231eb9c0298b78deee9ed3c1bbc7e We no longer do replay log locking in IptManager::new. Instead, we rely on the acquire_instance call in OnionService::launch, which ends up with ipt_mgr getting an InstanceHandle (which contains a lock guard). OnionServiceStateMgr is abolished; it existed to deal with the generics in the tor_persist::StateMgr API. state_dir has no generics (other than the T being loaded/stored). Many places (structs and argument lists) now have state_dir types which embody a path (or a CheckeDir) along with a lock, rather than separate path+lock+mistrust. The creation/startup code uses the new calls from state_dir. Other more minor changes: - StartupError::StateDirectoryInaccessible contains tor_persist::Error - test::create_storage_handles_from_state_dir changed and renamed, from _from_state_mgr. - replay::PersistFile's (separate) file lock is now fslock_guard's 2024-02-01T11:21:44Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-30T15:38:29Z urn:sha1:b84ac6628e5c17f99321e14a1f1349597d6786e0 We're going to change the payload of StateDirectoryInaccessible to tor_persist::Error, since that's what tor_persist::state_dir gives us, but then we can't use it here. 2024-02-01T11:21:44Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-30T12:47:40Z urn:sha1:d2f54164dcb05b3c8b5c9b7be522cdcba14e7ef3 The new state_dir types require &mut for storing, which is correct, but that means we can't have it in Immutable. 2024-02-01T11:21:44Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-30T12:41:50Z urn:sha1:03825a0ccccf33940c4812d213e1ea00410c39d2 These are here because that's what you get from the tor_persist singleton StageMgr API (for type erasure reasons). We're going to change these to tor_persist::state_dir types and those don't involve Arcs. 2023-12-13T17:03:23Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-12-12T15:34:38Z urn:sha1:06215d9270fe15e1c63a95dbe4adc9239baacc46 2023-12-04T18:58:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-11-23T14:54:51Z urn:sha1:dad7699e355bcbd0e02d3445710da7997a87c30e 2023-12-04T18:58:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-11-23T16:54:17Z urn:sha1:b98ca536c0d81470e5485aa1469077d245368e59 Previously IPT creation could only fail due to key generation failures or other kinds of internal error, which were very unlikely and treated as fatal. But with key persistence, IPT creation will be able to fail due to eg disk full. 2023-12-04T18:58:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-11-30T12:32:52Z urn:sha1:b7cdc31fcfd4121ab1c2140161df923446692da8 2023-12-04T18:58:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-11-22T15:55:12Z urn:sha1:0547d386cf35b967e0267ab2dbd9d514e403c250 Store the IPT manager's data structure to the provided storage manager. Keys are not persistent yet! And we must save the publication IPT set since it can have the only record of IPT publication times.