mirrors/arti.git/crates/tor-hsservice/src/ipt_mgr.rs, branch arti-v1.1.13mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.132024-02-01T20:51:18Ztor-hsservice: Use FatalError::KeystoreRace where possible.2024-02-01T20:51:18ZGabriela Moldovangabi@torproject.org2024-02-01T11:57:58Zurn:sha1:82b76eb9b66e4fe5b31acd402daab5e6e5d84c63tor-hsservice: Rewrite get_or_gen_key using KeyMgr::generate.2024-02-01T20:02:24ZGabriela Moldovangabi@torproject.org2024-01-31T17:30:03Zurn:sha1:1951d747f2f8b5516d0c1f5cba4a33e8b31db6e8
Now that `KeyMgr::generate` returns the generated key, we can tidy up
`get_or_gen_key`.
Part of #1074
tor-hsservice: Remove now-unused imports2024-02-01T11:21:44ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-30T15:52:23Zurn:sha1:4bd72e8258a4486d90597760e338813ac68f7a1dtor-hsservice: Drop now-unused fslock dependency2024-02-01T11:21:44ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-30T15:52:16Zurn:sha1:fa943898292e3110cba343064b2f48ad9f661a25
We're just using fslock-guard now.
tor-hsservice: Use tor_persist::state_dir, etc. (fmt)2024-02-01T11:21:44ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-30T16:12:33Zurn:sha1:4ccf20f165cb39e8f3da0a56eab55ea4fe1e4dd1tor-hsservice: Use tor_persist::state_dir2024-02-01T11:21:44ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-30T15:42:13Zurn:sha1:b4a7f0fca0d231eb9c0298b78deee9ed3c1bbc7e
We no longer do replay log locking in IptManager::new. Instead, we
rely on the acquire_instance call in OnionService::launch, which ends
up with ipt_mgr getting an InstanceHandle (which contains a lock
guard).
OnionServiceStateMgr is abolished; it existed to deal with the
generics in the tor_persist::StateMgr API. state_dir has no
generics (other than the T being loaded/stored).
Many places (structs and argument lists) now have state_dir types
which embody a path (or a CheckeDir) along with a lock, rather than
separate path+lock+mistrust.
The creation/startup code uses the new calls from state_dir.
Other more minor changes:
- StartupError::StateDirectoryInaccessible contains tor_persist::Error
- test::create_storage_handles_from_state_dir changed and renamed,
from _from_state_mgr.
- replay::PersistFile's (separate) file lock is now fslock_guard's
tor-hsservice: ipt_mgr: Move storage handle to state2024-02-01T11:21:44ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-30T12:47:40Zurn:sha1:d2f54164dcb05b3c8b5c9b7be522cdcba14e7ef3
The new state_dir types require &mut for storing, which is correct,
but that means we can't have it in Immutable.
tor-hsservice: storage: Move Arcs into type aliases2024-02-01T11:21:44ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-30T12:41:50Zurn:sha1:03825a0ccccf33940c4812d213e1ea00410c39d2
These are here because that's what you get from the tor_persist
singleton StageMgr API (for type erasure reasons). We're going to
change these to tor_persist::state_dir types and those don't involve
Arcs.
Merge branch 'ipt_parameters' into 'main'2024-01-31T16:24:08ZNick Mathewsonnickm@torproject.org2024-01-31T16:24:08Zurn:sha1:4a2f09b338f71a5c61f5ed390b7b6429e8317c0e
Clean up, tune, and correct various parameters related to introduction points.
Closes #1210
See merge request tpo/core/arti!1924Rename parameters for intro-point lifetime to match the spec.2024-01-31T15:10:36ZNick Mathewsonnickm@torproject.org2024-01-31T15:10:36Zurn:sha1:4700e9ce6c075851068fd7ba17324b3d787ff651
(Also, correct the comments that describe them.)
We may as well match the spec names when they aren't completely
bogus.
We are already renaming these parameters for this release, so it
isn't an additional breaking change.