mirrors/arti.git/crates/tor-hsrproxy/src/proxy.rs, branch arti-v1.4.6 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.6 2025-04-08T17:20:50Z metrics: tor-hsrproxy: Use a bespoke type for counter outcomes 2025-04-08T17:20:50Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-04-08T11:50:17Z urn:sha1:e02da4600e7a66bee5ac3dc57b708c0942bda895 Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2918#note_3185872 tor-hsrproxy: Export a connection count metric (fmt) 2025-04-08T17:20:50Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-04-02T16:23:22Z urn:sha1:016bcdbe6e93d7a565e33640c1363d5a79c7472d tor-hsrproxy: Export a connection count metric 2025-04-08T17:20:50Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-04-02T16:21:39Z urn:sha1:e9ee2f4204b5139de9946d86c942b6e62427f258 This proves the concept. Many more metrics will need to be added throughout the codebase. With this compiled in and enabled, I see this with curl: > ``` > # TYPE arti_hss_proxy_connections_failed_total counter > arti_hss_proxy_connections_failed_total{nickname="ztest",action="destroy_circuit"} 0 > arti_hss_proxy_connections_failed_total{nickname="ztest",action="ignore_stream"} 0 > arti_hss_proxy_connections_failed_total{nickname="ztest",action="forward"} 0 > arti_hss_proxy_connections_failed_total{nickname="ztest",action="reject_stream"} 0 > > # TYPE arti_hss_proxy_connections_total counter > arti_hss_proxy_connections_total{nickname="ztest",action="reject_stream"} 0 > arti_hss_proxy_connections_total{nickname="ztest",action="forward"} 1 > arti_hss_proxy_connections_total{nickname="ztest",action="destroy_circuit"} 0 > arti_hss_proxy_connections_total{nickname="ztest",action="ignore_stream"} 0 > > # TYPE arti_hss_proxy_connections_ok_total counter > arti_hss_proxy_connections_ok_total{nickname="ztest",action="destroy_circuit"} 0 > arti_hss_proxy_connections_ok_total{nickname="ztest",action="reject_stream"} 0 > arti_hss_proxy_connections_ok_total{nickname="ztest",action="ignore_stream"} 0 > arti_hss_proxy_connections_ok_total{nickname="ztest",action="forward"} 1 > ``` tor-hsrproxy: Move cloning into spawn 2025-04-08T17:20:50Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-04-02T14:25:17Z urn:sha1:65d8df00f87e70673cd46df699db71a66998e8aa This means that we can use the same variable names for the clones, which is considerably less confusing. extract tor_async_utils::oneshot into ::oneshot-fused-workaround 2024-08-28T14:27:46Z Jim Newsome jnewsome@torproject.org 2024-08-22T19:20:36Z urn:sha1:46f7f01092e6ac55e3e958dc3a2228b1d36e26a1 Having this in the `tor-async-utils` crate prevents us from doing both of the following without introducing a circular dependency: * using it in `tor-rtmock` (which we currently do, particularly in tests). * using `tor-rtmock` to test things in `tor-async-utils`. We don't do this yet, but it is generally sensible to do so. In particular we want to move the `stream_peak` module there, which is currently tested with `tor-rtmock`. Moving this into its own crate avoids this circular dependency. hsrproxy: Temporarily remove ability to config unix addresses 2024-01-16T16:56:28Z Nick Mathewson nickm@torproject.org 2024-01-16T16:56:28Z urn:sha1:36dcbe9382e12f32d2aecb159c8b51c14871a701 I'm taking this out for now since we don't have support for actually making these addresses work, and the current behavior will just ignore connections silently. Closes #1245 hsrproxy: downgrade remaining TODO HSS comments. 2024-01-09T19:59:18Z Nick Mathewson nickm@torproject.org 2024-01-09T19:59:18Z urn:sha1:c062efb82ee26c538477b5ffd95c255246bfff44 Apply 1 suggestion(s) to 1 file(s) 2023-12-11T18:08:13Z Ian Jackson iwj@torproject.org 2023-12-11T18:08:13Z urn:sha1:19546723df1b94af599315b706c7068f60ca3c44 hsrproxy: Log rate-limited failures of other types as well 2023-12-07T21:56:39Z Nick Mathewson nickm@torproject.org 2023-12-07T21:52:27Z urn:sha1:bac9aa4508967b13ee552a95027e9dfdcd6a82e5 We separate these from our failures to connect to a local proxy, since that is a much more common error. hsproxy: remove TODO about retroactive limits 2023-12-07T21:42:10Z Nick Mathewson nickm@torproject.org 2023-12-07T21:42:10Z urn:sha1:89dc5a749ea9679d69ddef575371f4a7edb0efb8 See arti#1153 for followup work here. The current behavior is IMO a decent default.