mirrors/arti.git/crates/tor-hsrproxy/src/config.rs, branch arti-v2.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.02026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
tor-hsrproxy: migrate to derive_deftly(TorConfig)2026-02-17T13:55:08ZNick Mathewsonnickm@torproject.org2026-02-11T20:02:40Zurn:sha1:bfcb554ebd136f15c44d860bd4f268e9904ab369Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
metrics: Discuss schema stability (currently, "no")2025-04-08T17:20:50ZIan Jacksonijackson@chiark.greenend.org.uk2025-04-08T12:17:17Zurn:sha1:63b1afba93c24519c20e95229e894d3e91cc658ator-hsrproxy: config: make ProxyActionDiscriminants private2025-04-08T17:20:50ZIan Jacksonijackson@chiark.greenend.org.uk2025-04-08T12:05:07Zurn:sha1:0818b110e24b573a217dac6c73e8ff1db31eb6fd
beta clippy pointed out that it shouldn't be exhaustive.
but `#[strum_discriminants(non_exhaustive)]` is rejected.
tor-hsrproxy: Export a connection count metric2025-04-08T17:20:50ZIan Jacksonijackson@chiark.greenend.org.uk2025-04-02T16:21:39Zurn:sha1:e9ee2f4204b5139de9946d86c942b6e62427f258
This proves the concept. Many more metrics will need to be added
throughout the codebase.
With this compiled in and enabled, I see this with curl:
> ```
> # TYPE arti_hss_proxy_connections_failed_total counter
> arti_hss_proxy_connections_failed_total{nickname="ztest",action="destroy_circuit"} 0
> arti_hss_proxy_connections_failed_total{nickname="ztest",action="ignore_stream"} 0
> arti_hss_proxy_connections_failed_total{nickname="ztest",action="forward"} 0
> arti_hss_proxy_connections_failed_total{nickname="ztest",action="reject_stream"} 0
>
> # TYPE arti_hss_proxy_connections_total counter
> arti_hss_proxy_connections_total{nickname="ztest",action="reject_stream"} 0
> arti_hss_proxy_connections_total{nickname="ztest",action="forward"} 1
> arti_hss_proxy_connections_total{nickname="ztest",action="destroy_circuit"} 0
> arti_hss_proxy_connections_total{nickname="ztest",action="ignore_stream"} 0
>
> # TYPE arti_hss_proxy_connections_ok_total counter
> arti_hss_proxy_connections_ok_total{nickname="ztest",action="destroy_circuit"} 0
> arti_hss_proxy_connections_ok_total{nickname="ztest",action="reject_stream"} 0
> arti_hss_proxy_connections_ok_total{nickname="ztest",action="ignore_stream"} 0
> arti_hss_proxy_connections_ok_total{nickname="ztest",action="forward"} 1
> ```
Fix AF_UNIX terminology in docs, comments, and error messages2025-03-24T13:58:54ZIan Jacksonijackson@chiark.greenend.org.uk2025-03-06T15:16:03Zurn:sha1:a60165c11c66c579d628a670de56bfcff494c1cdApply import alphabetisation churn2024-04-03T12:15:08ZIan Jacksonijackson@chiark.greenend.org.uk2024-04-02T14:49:54Zurn:sha1:3f39cf7767dba7dff7686b565aee5ea810c4c6d6Switch to derive-deftly2024-04-03T12:11:39ZIan Jacksonijackson@chiark.greenend.org.uk2024-04-02T11:58:49Zurn:sha1:b71d0bf6cd413650550b40ce81e02dc47ae2fa5e
This is the combination of a number of separate commits, many of which
were generated by seddery, and then rebased and squashed.
Cargo.toml
perl -i~ -pe 's{^derive-adhoc}{derive-deftly = "0.10"}' crates/*/Cargo.toml
(not regenerated during rebase)
update Cargo.lock
`cargo fetch` without --locked
(regenerated during rebase)
seddery
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{^use derive_adhoc}{use derive_deftly}'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bdefine_derive_adhoc\b}{define_derive_deftly}g'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bAdhoc\b}{Deftly}g if m{derive}'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\#\[derive_adhoc\b}{#[derive_deftly}g'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{use derive_adhoc}{use derive_deftly}'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bderive_adhoc\b}{derive_deftly_adhoc} if m{use.*deftly}'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bderive_adhoc!}{derive_deftly_adhoc!}'
(not regenerated during rebase)
Manually add `#[derive_deftly_adhoc]` where needed.
seddery
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\#\[adhoc\b}{#[deftly}g'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bderive_adhoc_template}{derive_deftly_template}'
(not regenerated during rebase)
Manually fix up an import
Manually update some builder attrs
Manually fix up tor_rtmock::time_core
This was missed in my seddery, due to me rebasing the branch and not
redoing the seddery.