mirrors/arti.git/crates/tor-hscrypto/src, branch arti-v1.1.5

hscrypto: Remove an incorrect comment.

2023-05-18T18:18:53Z

(It said that we want to deprecate all unescorted secret keys; in fact, only unescorted EdDSA secrets are bad.)

hscrypto: Replace ed25519 secret keys with keypairs

2023-05-18T18:18:53Z

Part of #798: We no longer use unescorted ed25519 secret keys.

hscrypto: Add comment about impl that will be removed after we address #798.

2023-05-03T16:25:32Z

Signed-off-by: Gabriela Moldovan

hscrypto: Add From impl for deriving KP_hsc_desc_enc out of KS_hsc_desc_enc.

2023-05-03T16:25:17Z

The `HsClientSecretKeys` stored in the HS client connection context only have the secret keys. Certain APIs (such as `HsDesc::parse`) expect a keypair (both `HsClientDescEncKey` and `HsClientDescEncSecretKey`). This `From` impl makes it possible to get a `HsClientDescEncKey` out of `HsClientDescEncSecretKey`. Signed-off-by: Gabriela Moldovan

Debug as hex strings for HsBlindId and HsDirIndex

2023-03-31T18:10:17Z

Stop requiring the caller to supply `AuthClient`s.

2023-03-31T14:04:15Z

`AuthClient`s were originally meant to represent parsed `auth-client` lines. In !1070, this struct was repurposed for representing individual authorized clients in the HS descriptor encoder. However, hidden services will likely use a list of public keys to represent the authorized clients rather than a list of `AuthClient`s, as the information from an `AuthClient` (`client_id`, `iv`, `encrypted_cookie`) likely won't be immediately available to the hidden service. This change updates the HS descriptor encoder to represent authorized clients as a list of `curve25519::PublicKey`s. As such, it is now the responsibility of the encoder to create the `client_id`, `iv`, and `encrypted_cookie` using the available keys, the unencrypted descriptor cookie, and HS subcredential. Signed-off-by: Gabriela Moldovan

tor-hscrypto: key blinding: Use consistent terminology

2023-03-28T11:47:14Z

* Don't ever use the words "parameter" or "param". These doesn't appear in the spec anywhere. * Use `h` as the variable name for the unclamped blinding factor, and `blinding_factor` in function names.

Use the type system to enforce use of blinded keys.

2023-03-27T10:45:51Z

Hidden services use blinded singing keys derived from the identity key to sign descriptor signing keys. Before this patch, the hidden descriptor builder represented its blinded signing keys (`blinded_id`) as plain `ed25519::Keypair`s. This was not ideal, as there was nothing preventing the caller from accidentally initializing `blinded_id` with an unblinded keypair. This introduces a new `HsBlindKeypair` type to represent blinded keypairs. Signed-off-by: Gabriela Moldovan

Add builder for encoding hidden service descriptors.

2023-03-24T18:57:49Z

This introduces the `NetdocBuilder` trait described in `netdoc-builder.md` and a new `tor-netdoc::doc::hsdesc::build` module, which exports the `HsDescBuilder`. Hidden services will use `HsDescBuilder` to build and encode hidden service descriptors. There are several TODOs in the code that I'm planning to address separately. Partially addresses #745. Signed-off-by: Gabriela Moldovan

Improve error from HsId parse of "www.B32.onion"

2023-03-09T18:09:08Z

And add some clarity and todos about address errors.