mirrors/arti.git/crates/tor-hscrypto/src, branch arti-v1.1.12

Merge branch 'wallclock-time' into 'main'

2023-12-13T16:09:53Z

tor-hscrypto: Return 0 if the timestamp is before the start of the TP. Closes #1155 See merge request tpo/core/arti!1828

tor-hscrypto: Return 0 if the timestamp is before the start of the TP.

2023-12-13T12:09:21Z

#1155 was happening because we couldn't compute the offset of the current time from the start of the _next_ TP (`TimePeriod::offset_within_period` expected `when` to come after the start of the TP). `TimePeriod::offset_within_period` now returns an offset of 0 for timestamps that come before the start of the TP, to support computing revision counters for the descriptors uploaded to the HsDirs from the ring associated with the next TP. Fixes #1155

hscrypto: Remove a "TODO HSS" about a no-longer-unused type.

2023-12-12T12:41:01Z

llcrypto: Hide the members of ExpandedKeypair.

2023-11-29T17:10:18Z

With this change, we no longer expose the ExpandedSecretKey unescorted, which makes it harder to misuse the API.

llcrypto: Remove ExpandedSecretKey export.

2023-11-29T16:11:39Z

This type was part of `hazmat`, and was no longer necessary anywhere in our codebase. (It had one remaining user, which was easy enough to remove.) By removing it, we remove the opportunity for using an unescorted ed25519 private key.

Remove RngCompatExt.

2023-11-29T15:55:04Z

This code was needed with the old version of dalek-cryptography, which wasn't compatible with up-to-date versions of the `rand` crate(s). But now that we've upgraded, we can drop this. (We could have left it around and deprecated it, but we are already making a breaking change to tor-llcrypto by upgrading dalek-cryptography.)

Convert to the latest versions of dalek-cryptography

2023-11-29T15:34:58Z

The main changes that we have to adjust for are as follows: * In x25519-dalek: * `StaticSecret` is now behind a feature. * `StaticSecret::new` is deprecated in favor of `StaticSecret::random_from_rng`. * StaticSecret no longer does its own clamping. * In ed25519-dalek: * `SecretKey` has (in effect) been renamed to `SigningKey`. The name `SecretKey` is now an alias for `[u8; 32]`. * `SigningKey` is effectively a keypair, since it contains a public key as well. * `PublicKey` has been renamed to `VerifyingKey`. * The functions to extract a signing key and verifying key have been renamed as you might expect. * `ExpandedSecretKey` has been moved to `hasmat` and no longer implements `sign`. * `ExpanededSecretKey` now has as its elements a scalar and a hash prefix. * Various functions that took `&[u8]` now take `&[u8; N]`. * We no longer need a wrapper for older versions of rand. There is a single test in tor-keymgr that does not pass. I've marked it as ignore for now, in hopes that @gabi-250 can help me figure it out. This closes #808. There are several changes I want to make before we merge, however. They are marked with TODO DALEK.

tor-hscrypto: Add a TODO re re-implementation of x25519 keypair gen

2023-11-23T17:30:44Z

IMO it is quite undesirable to have multiple copies of "gen a secret key and make a keypair out of it". Add a TODO HSS and and a ref to arti#1137 which is related.

tor-hscrypto: Add a docs TODO re the define_pk_keypair macro

2023-11-23T17:29:51Z

tor-hscrypto: Define Keypair conversions for all curve25519 newtypes

2023-11-23T17:29:51Z

1. Move `impl From for curve25519::StaticKeypair` (which was just a bespoke impl for HsClientDescEncKeypair) into the define_pk_keypair macro, so everything has it. Currently the only other user of the curve25519_pair feature is HsSvcNtorKey. 2. Provide the reverse conversion too.