mirrors/arti.git/crates/tor-hscrypto/src/pk.rs, branch arti-v2.5.0

hscrypto, linkspec, llcrypto: Use new redaction helpers

2026-06-10T17:17:33Z

This eliminates some string slicing.

everywhere: Add #[allow(clippy::string_slice)]

2026-06-09T16:02:36Z

This commit adds #[allow(clippy::string_slice)] to all functions in the code where string slices are used, alongside a TODO comment. We do this add the function header to have it consistent, as things like expression based allow's are still experimental.

maint: Run maint/add_warning to deny string slices

2026-06-09T15:36:01Z

This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit.

tor-hcrypto: Port to web-time-compat

2026-03-26T19:20:16Z

Fix name of clippy lint to unchecked_time_subtraction (2)

2025-11-06T11:28:22Z

Run maint/add_warning

tor-hscrypto: derive_deftly is mandatory again

2025-09-23T20:31:52Z

I don't know why this was breaking rust-recent-async-std-rustls, but oh well. Signed-off-by: hashcatHitman <3924-hashcatHitman@gitlab.torproject.org>

tor-(hs|ll)crypto: export cteq macros correctly

2025-09-23T19:52:04Z

The macros to deftly derive `ConstantTimeEq` and `PartialEq` (for `ConstantTimeEq`) are now only defined in `tor-llcrypto` and exported. The macro to deftly derive `ConstantTimeEq` is now struct only and uses `subtle::Choice::from(1)` for improved clarity. Signed-off-by: hashcatHitman <3924-hashcatHitman@gitlab.torproject.org>

tor-(hs|ll)crypto: deftly derive ConstantTimeEq

2025-09-23T08:25:49Z

This is my initial attempt at deriving ConstantTimeEq and PartialEq. This includes the previously missed HsSvcNtorKeypair and HsClientDescEncKeypair types. In tor-llcrypto, a few implementations still had to be done by hand, and some types which previously derived normal PartialEq now derive it with ConstantTimeEq. I could not figure out how to properly set up the macros such that they could be used both in the current crate and in others, so for the moment they are duplicated. Just so I can get feedback. Ideally, this will be replaced with a better solution before merge. Signed-off-by: hashcatHitman <3924-hashcatHitman@gitlab.torproject.org>

tor-hscrypto: constant time PartialEq for keys

2025-09-16T20:55:34Z

Implemented `subtle::ConstantTimeEq` for all of the following types: - `pk::HsIdKey` - `pk::HsIdKeypair` - `pk::HsBlindIdKey` - `pk::HsBlindIdKeypair` - `pk::HsDescSigningKey` - `pk::HsDescSigningKeypair` - `pk::HsIntroPtSessionIdKey` - `pk::HsIntroPtSessionIdKeypair` - `pk::HsSvcNtorKey` - `pk::HsSvcNtorSecretKey` - `pk::hs_client_intro_auth::HsClientIntroAuthKey` - `pk::hs_client_intro_auth::HsClientIntroAuthKeypair` - `pk::HsClientDescEncKey` - `pk::HsClientDescEncSecretKey` - `pk::HsSvcDescEncKey` - `pk::HsSvcDescEncSecretKey` - `pk::HsSvcDescEncKeypair` `PartialEq` has also been implemented for all listed types, using the constant time comparison under the hood. Signed-off-by: hashcatHitman <3924-hashcatHitman@gitlab.torproject.org>

tor-hscrypto: change redacted `HsId` from "???" to "[…]"

2025-08-25T15:22:16Z

Before: ```text INFO tor_hsservice: Generated a new identity for service bar: ???mad.onion ``` After: ```text INFO tor_hsservice: Generated a new identity for service foo: […]2qd.onion ```